Repository navigation
deps: upgrade BoringSSL to upstream 606d3a344 - #32521
Merged
Merged
Claude / Claude Code Review
completed
Jun 20, 2026 in 23m 9s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/tls/tls-connect-socket-churn.test.ts:55 |
ASAN RSS bound has only ~1.3x headroom over observed peak |
Annotations
Check warning on line 55 in test/js/node/tls/tls-connect-socket-churn.test.ts
claude / Claude Code Review
ASAN RSS bound has only ~1.3x headroom over observed peak
nit: The new ASAN/debug bound of 192 MB gives only ~1.28× headroom over the ~150 MB observed delta noted in the comment, while CLAUDE.md's "Tests reviewers reject" guideline calls for ~2× headroom on RSS thresholds. Since the `sslCtxLiveCount` check is the real regression guard here (per this PR's own `upgrade-boringssl.md`), consider bumping to ~300 MB to avoid intermittent flakes when ASAN quarantine occupancy varies with prior-test ordering.
Loading