Skip to content

test(install-proxy): run iterations sequentially to avoid squid saturation #34175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 1 commit into from
Closed

test(install-proxy): run iterations sequentially to avoid squid saturation #34175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions test/cli/install/bun-install-proxy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { beforeAll, it } from "bun:test";
import { beforeAll, expect, it } from "bun:test";
import { exec } from "child_process";
import { rm } from "fs/promises";
import { bunEnv, bunExe, dockerExe, isDockerEnabled, tempDirWithFiles } from "harness";
Expand Down Expand Up @@ -62,36 +62,35 @@ if (isDockerEnabled()) {
},
}),
};
const promises = new Array(5);
// this repro a hang when using a proxy, we run multiple times to make sure it's not a flaky test
// Regression test for the proxy hang (#19771). Run sequentially so all five
// installs don't push ~240 concurrent CONNECT tunnels through a single squid
// instance at once; a real hang is caught by the test-level timeout.
for (let i = 0; i < 5; i++) {
const package_dir = tempDirWithFiles("codex-" + i, files);

const { exited } = Bun.spawn([bunExe(), "install", "--ignore-scripts"], {
cwd: package_dir,
// @ts-ignore
env: {
...bunEnv,
BUN_INSTALL_CACHE_DIR: join(package_dir, ".bun-install-cache"),
TMPDIR: join(package_dir, ".tmp"),
BUN_TMPDIR: join(package_dir, ".tmp"),
HTTPS_PROXY: SQUID_URL,
HTTP_PROXY: SQUID_URL,
},
stdio: ["inherit", "inherit", "inherit"],
timeout: 20_000,
});
promises[i] = exited
.then(r => {
if (r !== 0) {
throw new Error("failed to install with exit code " + r);
}
})
.finally(() => {
return rm(package_dir, { recursive: true, force: true });
try {
await using proc = Bun.spawn([bunExe(), "install", "--ignore-scripts"], {
cwd: package_dir,
// @ts-ignore
env: {
...bunEnv,
BUN_INSTALL_CACHE_DIR: join(package_dir, ".bun-install-cache"),
TMPDIR: join(package_dir, ".tmp"),
BUN_TMPDIR: join(package_dir, ".tmp"),
HTTPS_PROXY: SQUID_URL,
HTTP_PROXY: SQUID_URL,
},
stdout: "pipe",
stderr: "pipe",
});
const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]);
if (exitCode !== 0) {
console.error(`iteration ${i} stdout:\n${stdout}`);
console.error(`iteration ${i} stderr:\n${stderr}`);
}
expect(exitCode).toBe(0);
} finally {
await rm(package_dir, { recursive: true, force: true });
}
}

await Promise.all(promises);
}, 60_000);
}, 120_000);
}
Loading