Guard the console and test-runner formatters against native stack overflow on deeply nested values by robobun · Pull Request #34884 · oven-sh/bun

jsc: seat StackCheck on the uncaught-exception printer's Formatter

robobun

committed

b71539e

Move StackCheck::init() into Formatter::new() instead of per-call-site

robobun

committed

9710a9d

test: assert uncaught printer completes (Bun version trailer), drop history comment

robobun

committed

4b3439a

Extend stack guard to pretty_format::Formatter; ignore stderr in test

robobun

committed

7b3da13

print_as_prelude: check stack before the !can_circ early-return

robobun

committed

a5e7897

test: include stmt in describe.each title so variants are distinguishable

robobun

committed

0f832d9

Drop now-unused StackCheck::update and its last caller in format_value

robobun

committed

be64e5b

Fold in the pretty_format test matrix from #34885 and make snapshot serialization throw on stack exhaustion

robobun

committed

143d380

Trim field and branch comments that restate the code

robobun

committed

8e893e5

Drop remaining field doc comment; rationale lives in the two construction sites

robobun

committed

62ce631

pretty_format: throw the stack overflow after the walk unwinds, not at the leaf

robobun

committed

e7f6acc

Trim comments on the deferred stack-overflow throw

robobun

committed

ee2036e

Test the throwing branch through a React element chain and pin a depth floor for pretty_format

robobun

committed

6f71143

pretty_format: pass the writer through the asymmetric matcher bridge unchanged

robobun

committed

ee06954

Trim comments on the matcher bridge

robobun

committed

5a24ce6

Navigation Menu

Repository navigation

Guard the console and test-runner formatters against native stack overflow on deeply nested values - #34884

Guard the console and test-runner formatters against native stack overflow on deeply nested values#34884
robobun wants to merge 16 commits into
mainfrom
farm/3f7b837f/fix-exception-printer-stackcheck

Commits on Sep 7, 2026

jsc: seat StackCheck on the uncaught-exception printer's Formatter

Move StackCheck::init() into Formatter::new() instead of per-call-site

test: assert uncaught printer completes (Bun version trailer), drop history comment

Extend stack guard to pretty_format::Formatter; ignore stderr in test

print_as_prelude: check stack before the !can_circ early-return

test: include stmt in describe.each title so variants are distinguishable

Drop now-unused StackCheck::update and its last caller in format_value

Fold in the pretty_format test matrix from #34885 and make snapshot serialization throw on stack exhaustion

Trim field and branch comments that restate the code

Drop remaining field doc comment; rationale lives in the two construction sites

pretty_format: throw the stack overflow after the walk unwinds, not at the leaf

Trim comments on the deferred stack-overflow throw

Test the throwing branch through a React element chain and pin a depth floor for pretty_format

pretty_format: pass the writer through the asymmetric matcher bridge unchanged

Trim comments on the matcher bridge

Commits on Sep 16, 2026

Merge remote-tracking branch 'origin/main' into push/34884