Skip to content

test(node-http): halve headersTimeout in test-http-server-request-timeouts-mixed #36563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 2 commits into from
Closed

test(node-http): halve headersTimeout in test-http-server-request-timeouts-mixed #36563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d75b52
test(node-http): halve headersTimeout in test-http-server-request-tim…
robobun Jul 31, 2026
71f6793
fix comment: CI asan lane is release (75 ms window), correct asan dur…
robobun Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/expected-durations.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion test/js/node/test/sequential/test-http-server-request-timeouts-mixed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ const requestBodyPart3 = '1234567890';
const responseOk = 'HTTP/1.1 200 OK\r\n';
const responseTimeout = 'HTTP/1.1 408 Request Timeout\r\n';

const headersTimeout = common.platformTimeout(2000);
// Upstream Node uses platformTimeout(2000). Every delay below is a ratio of
// headersTimeout, so halving the base keeps the same relative margins while
// halving wall-clock time. The narrowest window (request2's 408 before the
// 1.4x checkpoint) is 0.075 * headersTimeout: 75 ms on release lanes
// including release+ASAN where process.features.debug is false, and 150 ms on
// local debug builds where platformTimeout doubles the value.
const headersTimeout = common.platformTimeout(1000);
const connectionsCheckingInterval = headersTimeout / 8;

const server = createServer({
Expand Down
Loading