Repository navigation
console: output goes behind what process.stdout/stderr have buffered, as in Node #37128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dylan-conway
wants to merge
33
commits into
main
Choose a base branch
from
claude/node-console-stdout-compat-7d6001
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
90e0621
console, process.stdout/stderr: one stdio sink per fd, console writes…
dylan-conway cde99d8
Merge branch 'main' into claude/node-console-stdout-compat-7d6001
dylan-conway 584ddb3
clippy: ref_as_ptr, unnecessary_map_or, undocumented unsafe blocks
dylan-conway 40db416
review: stdio sink follow-ups
dylan-conway b704f36
ci: exception-scope discipline for console stream lookups, test fixes
dylan-conway 342d214
aarch64 baseline: use the allowlisted acq_rel outline atomic for STDI…
dylan-conway e6f489e
FileSink::write_with: report this call's byte count, not the flushed …
dylan-conway 8566d73
stdio sink: only trust RWF_NOWAIT on pipefs pipes; tolerate an fd clo…
dylan-conway 70e70ac
writeToObservedStream: same removeListener guard as Console.write
dylan-conway 7bd8448
review: latch autoflush errors on stdio sinks; downgrade sinks after …
dylan-conway b7a141f
console: drop SCRATCH_KEEP; the scratch buffer shrinks back to SPILL_…
dylan-conway cec5076
Merge remote-tracking branch 'origin/main' into claude/node-console-s…
dylan-conway 0e78647
process.stdout/stderr.write keep accepting a bare ArrayBuffer / Share…
dylan-conway 7eaf6ab
Address risk review: writer coalescing, async Bun.write, killable exi…
dylan-conway f35776a
FileSink: make the RWF_NOWAIT flag field Linux-only instead of allow(…
dylan-conway 4b248ac
Merge remote-tracking branch 'origin/main' into claude/node-console-s…
dylan-conway 1e52b84
Merge remote-tracking branch 'origin/main' into claude/node-console-s…
dylan-conway e63575b
exit drain: only un-hook signals that were being forwarded to JS list…
dylan-conway c167a8b
docs: put three misplaced doc comments back on the items they describe
dylan-conway b5a2451
review: idempotent RWF_NOWAIT branch in stdio_go_nonblocking; Stream.…
dylan-conway 7d7d6dc
stdio_go_nonblocking: never re-set O_NONBLOCK once a spawn has handed…
dylan-conway 67b116c
console emit: decide colours before taking the scratch buffer
dylan-conway 46f1c79
Merge remote-tracking branch 'origin/main' into claude/node-console-s…
dylan-conway ab797ac
console: stop (and report once) after a failed spill; docs: Bun.write…
dylan-conway f07b71e
napi test fixture: allocate the finalizer objects in a callee frame a…
dylan-conway a41ced3
Merge remote-tracking branch 'origin/main' into claude/node-console-s…
dylan-conway 9033ecd
Cut the PR down to one change: console.* flushes what process.stdout/…
dylan-conway 3464a31
FileSink: do not settle a pending write whose slot backed up again, a…
dylan-conway 83e1363
console: flush process.stdout/stderr's sink the way the event loop do…
dylan-conway 8658131
console: the flush only moves bytes and leaves a write error for the …
dylan-conway 75e6511
test: do not call console.assert(false), which fails exception valida…
dylan-conway 1954570
Merge remote-tracking branch 'origin/main' into claude/node-console-s…
dylan-conway 7f91520
console: output for a backed-up process.stdout/stderr goes into that …
dylan-conway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.