Skip to content

bundler: abort on allocation failure when enqueuing a plugin-resolved entry point #41041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 1 commit into from
Closed

bundler: abort on allocation failure when enqueuing a plugin-resolved entry point #41041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mordant-baseline.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[bun_ast]

[bun_bundler]
"defaulted_failure:src/bundler/bundle_v2.rs" = 2
"narrowed_two_ways:src/bundler/bundle_v2.rs" = 1

[bun_core]
Expand Down
19 changes: 11 additions & 8 deletions src/bundler/bundle_v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4815,14 +4815,17 @@ pub mod bv2_impl {
return;
};
let mut resolved = resolved;
let Ok(source_index) = this.enqueue_entry_item(
&mut resolved,
true,
target,
resolve.import_record.loader,
) else {
return;
};
// `enqueue_entry_item` fails only on allocation, after it has
// already counted the pending parse task: a silent return here
// would leave the build waiting for a task that never runs.
let source_index = this
.enqueue_entry_item(
&mut resolved,
true,
target,
resolve.import_record.loader,
)
.expect("oom");

// Store the original entry point name for virtual entries that fall back to file resolution
if let Some(idx) = source_index {
Expand Down
Loading