Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .buildkite/ci.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,6 @@ const emojiMap = {
ubuntu: ["🐧", "ubuntu"],
alpine: ["🐧", "alpine"],
aws: ["☁️", "aws"],
amazonlinux: ["🐧", "aws"],
nix: ["🐧", "nix"],
windows: ["🪟", "windows"],
true: ["✅", "white_check_mark"],
false: ["❌", "x"],
Expand All @@ -153,8 +151,6 @@ const emojiMap = {
clipboard: ["📋", "clipboard"],
package: ["📦", "package"],
rocket: ["🚀", "rocket"],
openbsd: ["🐡", "openbsd"],
netbsd: ["🚩", "netbsd"],
freebsd: ["😈", "freebsd"],
};

Expand All @@ -173,8 +169,8 @@ function getBuildkiteEmoji(emoji: Emoji): string {

/** A target's abi. glibc is the absence of one, so "gnu" is never spelled here. */
type Abi = Exclude<HostAbi, "gnu">;
type Distro = "debian" | "ubuntu" | "alpine" | "amazonlinux";
type Tier = "latest" | "previous" | "oldest" | "eol" | "beta";
type Distro = "debian" | "ubuntu" | "alpine";
type Tier = "latest" | "previous" | "oldest" | "beta";
type Profile = "release" | "assert" | "debug" | "asan";

interface Target {
Expand Down Expand Up @@ -227,7 +223,6 @@ type Platform = Target & {
distro?: Distro;
release: string;
tier?: Tier;
features?: string[];
};

type AzureVmTier = "build" | "test";
Expand Down Expand Up @@ -1280,7 +1275,6 @@ interface PipelineOptions {
skipSizeCheck?: OptionFlag;
forceBuilds?: OptionFlag;
signWindows?: OptionFlag;
dryRun?: OptionFlag;
canary?: number;
buildPlatforms?: Platform[];
testPlatforms?: Platform[];
Expand Down Expand Up @@ -1518,7 +1512,6 @@ async function getPipelineOptions(): Promise<PipelineOptions | undefined> {
getBuildProfiles().map(profile => ({ ...getSelectedPlatform(testPlatformsMap, key), profile })),
)
: Array.from(testPlatformsMap.values()),
dryRun: parseBoolean(options["dry-run"]),
};
}

Expand Down Expand Up @@ -1549,7 +1542,6 @@ async function getPipelineOptions(): Promise<PipelineOptions | undefined> {
skipTests: parseOption(/\[(skip tests?|no tests?|only builds?)\]/i),
skipSizeCheck: parseOption(/\[(skip size( check)?|allow size)\]/i),
signWindows: parseOption(/\[(sign windows)\]/i),
dryRun: parseOption(/\[(dry run)\]/i),
buildPlatforms: Array.from(buildPlatformsMap.values()),
testPlatforms: Array.from(testPlatformsMap.values()),
};
Expand Down Expand Up @@ -1715,7 +1707,7 @@ async function getPipeline(options: PipelineOptions = {}): Promise<Pipeline | un
steps.push({ key: "images", group: getBuildkiteEmoji("aws"), steps: imageSteps });
}

const { skipBuilds, forceBuilds, dryRun } = options;
const { skipBuilds, forceBuilds } = options;

let buildId: string | undefined;
if (skipBuilds && !forceBuilds) {
Expand Down
2 changes: 0 additions & 2 deletions packages/bun-usockets/src/internal/eventing/epoll_kqueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,4 @@ struct us_poll_t {
} state;
};

#undef FD_BITS

#endif // EPOLL_KQUEUE_H
1 change: 0 additions & 1 deletion packages/bun-usockets/src/internal/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,6 @@ struct us_udp_socket_t {
* and use it to build a proper and full sockaddr_in or sockaddr_in6 for every received packet */
uint16_t port;
uint16_t closed : 1;
uint16_t connected : 1;
uint16_t shared_fd : 1;
struct us_udp_socket_t *next;
};
Expand Down
2 changes: 0 additions & 2 deletions packages/bun-usockets/src/quic.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ struct us_quic_stream_s {
lsquic_stream_t *stream;
us_quic_socket_context_t *ctx;
struct us_quic_hset *hset;
int headers_delivered;
int fin_delivered;
/* Set by us_quic_flush_from_on_write, cleared by on_write. */
int flush_on_write;
Expand Down Expand Up @@ -696,7 +695,6 @@ static int us_quic_deliver_hset(lsquic_stream_t *stream, us_quic_stream_t *s) {
us_quic_hset_finalize(hset);
us_quic_hset_free(s->hset);
s->hset = hset;
s->headers_delivered = 1;
if (s->ctx->on_stream_headers) s->ctx->on_stream_headers(s);
return s->stream ? 1 : -1;
}
Expand Down
2 changes: 0 additions & 2 deletions packages/bun-usockets/src/udp.c
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ struct us_udp_socket_t *us_create_udp_socket_from_fd(

udp->closed = 0;
udp->shared_fd = shared ? 1 : 0;
udp->connected = 0;
udp->on_data = data_cb;
udp->on_drain = drain_cb;
udp->on_close = close_cb;
Expand Down Expand Up @@ -271,7 +270,6 @@ struct us_udp_socket_t *us_create_udp_socket(

udp->closed = 0;
udp->shared_fd = 0;
udp->connected = 0;
udp->on_data = data_cb;
udp->on_drain = drain_cb;
udp->on_close = close_cb;
Expand Down
1 change: 0 additions & 1 deletion packages/bun-uws/src/Http2Context.h
Original file line number Diff line number Diff line change
Expand Up @@ -1835,7 +1835,6 @@ inline bool Http2Response::sendTerminatingChunk(bool) {

inline bool Http2Response::internalEnd(std::string_view body, uint64_t totalSize, bool optional, bool) {
if (dead || localClosed) return !optional;
data.totalSize = totalSize;
Http2Connection *c = conn;

if (!(data.state & Http2ResponseData::HTTP_WRITE_CALLED)) {
Expand Down
1 change: 0 additions & 1 deletion packages/bun-uws/src/Http2ResponseData.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ struct Http2ResponseData {
bool endAfterDrain = false;

uint64_t offset = 0;
uint64_t totalSize = 0;
uint8_t state = HTTP_RESPONSE_PENDING;

void appendHeader(const char *name, unsigned nlen, const char *value, unsigned vlen) {
Expand Down
5 changes: 0 additions & 5 deletions src/js/node/dgram.ts
Original file line number Diff line number Diff line change
Expand Up @@ -583,11 +583,6 @@ Socket.prototype.bind = function (port_, address_ /* , callback */) {

if (port !== null && typeof port === "object" && typeof port.recvStart === "function") {
throwNotImplemented("Socket.prototype.bind(handle)");
/*
replaceHandle(this, port);
startListening(this);
return this;
*/
}

// Open an existing fd instead of creating a new one.
Expand Down
12 changes: 2 additions & 10 deletions src/runtime/bake/client/data-view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ export class DataViewReader {
return value;
}

u16() {
const value = this.view.getUint16(this.cursor, true);
this.cursor += 2;
return value;
}

u8() {
const value = this.view.getUint8(this.cursor);
this.cursor += 1;
Expand Down Expand Up @@ -56,17 +50,15 @@ export class DataViewWriter {
view: DataView<ArrayBuffer>;
uint8ArrayView: Uint8Array;
cursor: number;
capacity: number;

static initCapacity(capacity: number) {
const view = new DataView(new ArrayBuffer(capacity));
return new DataViewWriter(view, 0, capacity);
return new DataViewWriter(view, 0);
}

constructor(view: DataView<ArrayBuffer>, cursor: number, capacity: number) {
constructor(view: DataView<ArrayBuffer>, cursor: number) {
this.view = view;
this.cursor = cursor;
this.capacity = capacity;
this.uint8ArrayView = new Uint8Array(view.buffer);
}

Expand Down
4 changes: 0 additions & 4 deletions src/runtime/bake/client/overlay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,6 @@ function updateRuntimeErrorOverlay(err: RuntimeError) {
}

function updateBuildErrorOverlay({ remountAll = false }) {
let totalCount = 0;

const owners = remountAll ? buildErrors.keys() : updatedErrorOwners;

for (const owner of owners) {
Expand All @@ -539,8 +537,6 @@ function updateBuildErrorOverlay({ remountAll = false }) {
continue;
}

totalCount += data.messages.length;

// Create the element for the root if it does not yet exist.
if (!dom || remountAll) {
let fileName;
Expand Down
5 changes: 1 addition & 4 deletions src/uws_sys/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,7 @@ pub use bun_core::Timespec;
// `UnsafeCell<[u8;0]>` / `!Freeze` rationale; with UnsafeCell the reference is
// ABI-identical to a non-null pointer, which lets us declare value-typed shims
// as `safe fn` and drop per-call-site `unsafe { }`.
bun_core::opaque_extern!(
pub us_loop_t, pub us_socket_context_t, pub us_udp_socket_t, pub us_udp_packet_buffer_t,
pub UpgradedDuplex, pub WindowsNamedPipe,
);
bun_core::opaque_extern!(pub UpgradedDuplex, pub WindowsNamedPipe);

pub mod socket_transfer {
use super::LIBUS_SOCKET_DESCRIPTOR;
Expand Down
Loading