Skip to content

node:quic: report a datagram's status under the id kept in its lsquic frame #44680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 6 commits into
base: main
Choose a base branch
from
Open

node:quic: report a datagram's status under the id kept in its lsquic frame #44680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e451fb
node:quic: report a datagram's status under the id kept in its lsquic…
robobun Oct 6, 2026
7426614
test(node:quic): fail the datagram tests with the cause when a sessio…
robobun Oct 16, 2026
44ae42c
test(node:quic): release the endpoints and sessions of the datagram t…
robobun Oct 16, 2026
a35d42b
Merge remote-tracking branch 'origin/main' into robobun/a366d935/quic…
robobun Oct 18, 2026
274e848
test(node:quic): make the datagram tests pass the type check of test/
robobun Oct 18, 2026
0840e16
ci: retrigger
robobun Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/bun-usockets/src/node_quic_shim.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ struct us_nq_vtable {
void (*on_stream_reset)(void *stream_ctx, int how, uint64_t error_code);
ssize_t (*on_dg_write)(void *conn_ctx, void *buf, size_t buf_sz);
void (*on_datagram)(void *conn_ctx, const void *buf, size_t sz);
void (*on_datagram_status)(void *conn_ctx, unsigned count, int acked);
void (*on_datagram_status)(void *conn_ctx, uint64_t id, int status);
void (*on_early_data_failed)(void *conn_ctx);
void (*on_path_switch)(void *conn_ctx, int validated, int is_preferred,
const struct sockaddr *new_local,
Expand Down Expand Up @@ -149,11 +149,14 @@ static void nq_on_datagram(lsquic_conn_t *c, const void *buf, size_t sz) {
vt->on_datagram(ctx, buf, sz);
}
}
static void nq_on_datagram_status(lsquic_conn_t *c, unsigned count, int acked) {
/* lsquic_sys mirrors these values as LSQ_DG_*. */
_Static_assert(LSQ_DG_ACKED == 0 && LSQ_DG_LOST == 1 && LSQ_DG_UNSENT == 2,
"lsquic_sys::LSQ_DG_* must match enum lsquic_dg_status");
static void nq_on_datagram_status(lsquic_conn_t *c, uint64_t id, int status) {
void *ctx = (void *) lsquic_conn_get_ctx(c);
if (ctx) {
struct us_nq_vtable *vt = *(struct us_nq_vtable **) ctx;
vt->on_datagram_status(ctx, count, acked);
vt->on_datagram_status(ctx, id, status);
}
}
static void nq_on_early_data_failed(lsquic_conn_t *c) {
Expand Down
Loading
Loading