Skip to content

Remove dead code from Exception.h, ExceptionOr.h, ErrorCode.h, InspectorHTTPServerAgent.cpp, and JSBuffer.cpp #45725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead code from Exception.h, ExceptionOr.h, ErrorCode.h, InspectorHTTPServerAgent.cpp, and JSBuffer.cpp #45725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/jsc/bindings/ErrorCode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ void throwTypeErrorOrOutOfMemory(JSC::JSGlobalObject*, JSC::ThrowScope&, const W
class ErrorCodeCache : public JSC::JSInternalFieldObjectImpl<NODE_ERROR_COUNT> {
public:
using Base = JSInternalFieldObjectImpl<NODE_ERROR_COUNT>;
using Field = ErrorCode;

DECLARE_EXPORT_INFO;

Expand Down
7 changes: 0 additions & 7 deletions src/jsc/bindings/Exception.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,11 @@ class Exception {
String m_extra;
};

Exception isolatedCopy(Exception&&);

inline Exception::Exception(ExceptionCode code, String message, String extra)
: m_code { code }
, m_message { WTF::move(message) }
, m_extra { WTF::move(extra) }
{
}

inline Exception isolatedCopy(Exception&& value)
{
return Exception { value.code(), value.releaseMessage().isolatedCopy(), value.releaseExtra().isolatedCopy() };
}

}
9 changes: 0 additions & 9 deletions src/jsc/bindings/ExceptionOr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ template<> class ExceptionOr<void> {
std::expected<void, Exception> m_value;
};

ExceptionOr<void> isolatedCopy(ExceptionOr<void>&&);

template<typename ReturnType> inline ExceptionOr<ReturnType>::ExceptionOr(Exception&& exception)
: m_value(makeUnexpected(WTF::move(exception)))
{
Expand Down Expand Up @@ -186,13 +184,6 @@ inline Exception ExceptionOr<void>::releaseException()
return WTF::move(m_value.error());
}

inline ExceptionOr<void> isolatedCopy(ExceptionOr<void>&& value)
{
if (value.hasException())
return isolatedCopy(value.releaseException());
return {};
}

template<typename T> inline constexpr bool IsExceptionOr = WTF::IsTemplate<std::decay_t<T>, ExceptionOr>::value;

template<typename T, bool isExceptionOr = IsExceptionOr<T>> struct TypeOrExceptionOrUnderlyingTypeImpl;
Expand Down
2 changes: 0 additions & 2 deletions src/jsc/bindings/InspectorHTTPServerAgent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,6 @@ extern "C" {

typedef int ServerId;
typedef int HotReloadId;
typedef int RouteId;
typedef int RequestId;

[[ZIG_EXPORT(nothrow)]] void Bun__HTTPServerAgent__notifyServerStarted(Inspector::InspectorHTTPServerAgent* agent, ServerId serverId, HotReloadId hotReloadId, const BunString* address, double startTime, void* serverInstance)
{
Expand Down
2 changes: 0 additions & 2 deletions src/jsc/bindings/JSBuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2763,8 +2763,6 @@ JSC_ANNOTATE_HOST_FUNCTION(JSBufferConstructorConstruct, JSBufferConstructor::co
class JSBuffer : public JSC::JSNonFinalObject {

DECLARE_INFO;

static constexpr JSC::JSTypeRange typeRange = { Uint8ArrayType, Uint8ArrayType };
};

const ClassInfo JSBuffer::s_info = {
Expand Down
Loading