Skip to content

Remove dead code from bun_lsquic_sys, bun_trim, and bun_sema_standalone #47355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead code from bun_lsquic_sys, bun_trim, and bun_sema_standalone #47355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions packages/bun-usockets/src/node_quic_shim.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,8 @@ NQ_SET(max_datagram_frame_size, unsigned short)
NQ_SET(max_h3_header_pairs, unsigned short)
NQ_SET(max_h3_header_bytes, unsigned)
NQ_SET(allow_migration, int)
NQ_SET(scid_len, unsigned)
NQ_SET(silent_close, int)
NQ_SET(cc_algo, unsigned)
NQ_SET(delay_onclose, int)

#define NQ_GET(f, ty) \
ty us_nq_settings_get_##f(const struct lsquic_engine_settings *s) { return s->es_##f; }
Expand Down
4 changes: 0 additions & 4 deletions src/lsquic_sys/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,8 @@ unsafe extern "C" {
blob: *const u8,
len: usize,
);
fn us_nq_settings_set_scid_len(s: *mut lsquic_engine_settings, v: c_uint);
fn us_nq_settings_set_silent_close(s: *mut lsquic_engine_settings, v: c_int);
fn us_nq_settings_set_cc_algo(s: *mut lsquic_engine_settings, v: c_uint);
fn us_nq_settings_set_delay_onclose(s: *mut lsquic_engine_settings, v: c_int);
}

pub struct Settings {
Expand Down Expand Up @@ -368,10 +366,8 @@ settings_setters! {
max_h3_header_pairs => us_nq_settings_set_max_h3_header_pairs : u16,
max_h3_header_bytes => us_nq_settings_set_max_h3_header_bytes : c_uint,
allow_migration => us_nq_settings_set_allow_migration : c_int,
scid_len => us_nq_settings_set_scid_len : c_uint,
silent_close => us_nq_settings_set_silent_close : c_int,
cc_algo => us_nq_settings_set_cc_algo : c_uint,
delay_onclose => us_nq_settings_set_delay_onclose : c_int,
}

/// Borrowed `lsquic_conn_t`. lsquic owns the conn and frees it after
Expand Down
1 change: 0 additions & 1 deletion src/sema/standalone/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ path = "main.rs"
test_support = ["bun_sema/test_support", "bun_threading/test_support"]

[dependencies]
bun_sema_parser.workspace = true
bun_sema = { workspace = true, features = ["baselines"] }
bun_sema_driver.workspace = true
bun_sema_baselines.workspace = true
Expand Down
1 change: 0 additions & 1 deletion src/trim/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ bun_removable_features.workspace = true
bun_options_types.workspace = true
bun_exe_format.workspace = true
bun_core.workspace = true
thiserror.workspace = true
strum.workspace = true

[dev-dependencies]
Expand Down
Loading