nexus: trim trailing nulls in omicron.public.ereport serials#10452
Merged
Conversation
jgallagher
reviewed
May 18, 2026
smklein
approved these changes
May 18, 2026
| ctx.client | ||
| .batch_execute(&format!( | ||
| " | ||
| INSERT INTO omicron.public.ereport ( |
hawkw
added a commit
that referenced
this pull request
May 19, 2026
…10457) This updates the MGS dep to oxidecomputer/management-gateway-service@745a508. Along with #10452, this is necessary for #10437. I had considered waiting to get oxidecomputer/management-gateway-service#494 in the update as well, and may still do so depending on when I hear back from people about various things. But, I did want to [take a moment to get some feedback][1] from potential actual users of the faux-mgs interface on whether they actually like my (perhaps unnecessarily cutesy) output format before merging it. [1]: oxidecomputer/management-gateway-service#494 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a (data-only) migration to remove trailing NUL characters from the
serial_numbercolumn inomicron.public.ereport. This way, we can query and JOIN on OXV2 serials without encountering sadness. Alongside #10457, which picks up the MGS patch to remove these characters from new ereports, this will fix #10437. Sigh.