[3/n] [ls-apis] track sled-agent-rack-setup as a separate subcomponent#10459
Conversation
Created using spr 1.3.6-beta.1
sunshowers
commented
May 19, 2026
| # upgrade DAG, so that sled-agent-rack-setup doesn't impose any ordering | ||
| # constraints on the upgrade DAG. | ||
| subcomponents = [ | ||
| { name = "sled-agent-rack-setup", inside = "omicron-sled-agent", lifecycle = "rack-init" }, |
Contributor
Author
There was a problem hiding this comment.
Looking for feedback on the inside thing. I tried autodiscovering the inside by looking at the dependency graph but honestly that was a complete mess that was hard to understand both in the code and in this manifest. I feel like having an explicit inside makes both layers easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSS has very different semantics from the rest of Sled Agent, and the recent split to put it in another crate (#10340) gives us a change to handle this divergence in a principled manner.
Introduce two new notions to ls-apis:
"steady-state"by default, but"rack-init"for RSSThis separation also gives us a chance to do a lot of cleanup within the API manifest:
not-deployedevaluation for RSS goes away, since that knowledge can be derived from therack-initlifecycleDepends on: