Skip to content

chore: entry count statistics for cache#428

Open
cheb0 wants to merge 3 commits into
mainfrom
0-cache-entries-count-metrics
Open

chore: entry count statistics for cache#428
cheb0 wants to merge 3 commits into
mainfrom
0-cache-entries-count-metrics

Conversation

@cheb0
Copy link
Copy Markdown
Collaborator

@cheb0 cheb0 commented May 21, 2026

Description

allow to see how many blocks are in the cache right now on dashboards


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.62%. Comparing base (03b2cad) to head (470b9ec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #428   +/-   ##
=======================================
  Coverage   70.62%   70.62%           
=======================================
  Files         219      219           
  Lines       16970    17017   +47     
=======================================
+ Hits        11985    12019   +34     
- Misses       4089     4099   +10     
- Partials      896      899    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin requested review from eguguchkin and forshev May 25, 2026 11:25
Comment thread cache/metrics.go Outdated
m.MissTotal.Inc()
m.SizeOccupied.Add(float64(size))
m.MissLatency.Add(latencySec)
m.EntriesOccupied.Inc()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems likeEntriesOccupied metric is identical to MissTotal

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. I deleted EntriesOccupied metric

@cheb0 cheb0 force-pushed the 0-cache-entries-count-metrics branch from 7da75c2 to 521263f Compare May 26, 2026 06:09
@github-actions
Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggWide/size=1000000-4 2c48a6 324fb8
467.00 B/op 545.00 B/op 1.17 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants