Repository navigation
Conversation
Change the default value of SESSION_COOKIE_SAMESITE from None to "Lax". When set to None, Flask does not include the SameSite attribute on session cookies, relying on browser defaults. While modern browsers default to Lax behavior when the attribute is absent, setting it explicitly ensures consistent CSRF defense across all browser versions, including older ones that do not apply the Lax default. Django has defaulted to "Lax" since 2.1 (2018). This aligns Flask with the ecosystem standard. Applications that require cross-site cookie behavior can set SESSION_COOKIE_SAMESITE to None (with SESSION_COOKIE_SECURE=True).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the default value of
SESSION_COOKIE_SAMESITEfromNoneto"Lax".When set to
None, Flask does not include theSameSiteattribute on session cookies, relying on browser defaults. While modern browsers default toLaxbehavior when the attribute is absent, setting it explicitly ensures consistent CSRF defense-in-depth across all browser versions, including older ones that do not apply theLaxdefault.Django has defaulted to
"Lax"since 2.1 (2018). Express.js and Rails also default toLax. This aligns Flask with the ecosystem standard.Applications that require cross-site cookie behavior can set
SESSION_COOKIE_SAMESITEtoNone(withSESSION_COOKIE_SECURE=True).All existing tests pass with this change (486 passed, 0 regressions).