Skip to content

remove unicode host test - #5962

Merged
davidism merged 1 commit into
mainfrom
remove-unicode-test
Mar 24, 2026
Merged

davidism merged 1 commit into
mainfrom
remove-unicode-test

Conversation

@davidism

Copy link
Copy Markdown
Member

This test is invalid, the Host header cannot contain non-ASCII. It was added in #2994. It appears there was some confusion over Python 2/3 handling of strings, rather than testing this because it was a valid Host header.

closes #5961

@davidism
davidism force-pushed the remove-unicode-test branch from 89a3fd5 to 91c6b3f Compare March 24, 2026 13:54
@davidism
davidism merged commit 7ef2946 into main Mar 24, 2026
14 checks passed
@davidism
davidism deleted the remove-unicode-test branch March 24, 2026 13:55
@ap-wtioit

Copy link
Copy Markdown

Would have been better to fix the test to test with the IDNA compatible host header.

@davidism

Copy link
Copy Markdown
Member Author

That's the test below the one removed

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flask 3.1.3 test (test_environ_for_valid_idna_completes) breaks after Werkzeug update from 3.1.6 to 3.1.7

2 participants