Repository navigation
Conversation
When a Celery task fails, `result.ready()` evaluates to `True` but `result.successful()` is `False`. Calling `result.get()` without `propagate=False` on a failed task will re-raise the task's exception, causing the Flask endpoint to crash with a 500 Internal Server Error instead of returning the task's failed status. Additionally, if `result.result` is an Exception object, returning it directly in the dictionary will cause a `TypeError` during JSON serialization. Affected files: views.py Signed-off-by: Tang Vu <vuminhtang2212@gmail.com>
Member
|
Do not have AI tools open issues or create PRs. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Code Quality
Problem
When a Celery task fails,
result.ready()evaluates toTruebutresult.successful()isFalse.Calling
result.get()withoutpropagate=Falseon a failed task will re-raise the task's exception, causing the Flask endpoint to crash with a 500 Internal Server Error instead of returning the task's failed status.Additionally, if
result.resultis an Exception object, returning it directly in the dictionary will cause aTypeErrorduring JSON serialization.Severity:
mediumFile:
examples/celery/src/task_app/views.pySolution
When a Celery task fails,
result.ready()evaluates toTruebutresult.successful()isFalse.Calling
result.get()withoutpropagate=Falseon a failed task will re-raise the task's exception, causing the Flask endpoint to crash with a 500 Internal Server Error instead of returning the task's failed status.Additionally, if
result.resultis an Exception object, returning it directly in the dictionary will cause aTypeErrorduring JSON serialization.Changes
examples/celery/src/task_app/views.py(modified)🤖 About this PR
This pull request was generated by ContribAI, an AI agent
that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.
We appreciate your time reviewing this contribution!
Closes #5965