Repository navigation
Security: Path traversal risk in Blueprint.open_resource - #5982
Closed
barttran2k wants to merge 1 commit into
Closed
barttran2k wants to merge 1 commit into
barttran2k wants to merge 1 commit into
Conversation
The open_resource method joins the user-provided 'resource' parameter with root_path using os.path.join without sanitizing for path traversal sequences (e.g., '../'). If a developer passes user-controlled input to this method, it could allow reading arbitrary files on the filesystem. Affected files: blueprints.py Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
Member
|
This is not how to report a security issue. It's also not a security issue. Do not rely on output generated by LLMs, understand the code yourself before working on or submitting anything to any project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The open_resource method joins the user-provided 'resource' parameter with root_path using os.path.join without sanitizing for path traversal sequences (e.g., '../'). If a developer passes user-controlled input to this method, it could allow reading arbitrary files on the filesystem.
Severity:
lowFile:
src/flask/blueprints.pySolution
Add path traversal validation by resolving the final path and checking it is still within root_path: resolved = os.path.realpath(path); if not resolved.startswith(os.path.realpath(self.root_path)): raise ValueError('Path traversal detected').
Changes
src/flask/blueprints.py(modified)Testing