ENH: Officially support Timedelta arguments in Timestamp.round/floor/ceil (GH#63687)#63773
ENH: Officially support Timedelta arguments in Timestamp.round/floor/ceil (GH#63687)#63773randolf-scholz wants to merge 6 commits intopandas-dev:mainfrom
Conversation
randolf-scholz
force-pushed
the
timestamp_round_timedelta_main
branch
3 times, most recently
from
59832a3 to
f76bce2
Compare
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
I see you have this and #63772 both closing the same issue. Are you pursuing both of them, or can we close one and just focus on the other? |
|
@jbrockmendel The other PR is intentionally marked as draft and builds on top of this one, extending it by the "optional" features of the issue. But as you can see, the tests are failing and I'd suggest to ignore #63772 it for the time being. |
…ceil (GH#63687) - Update type hints to accept str | Timedelta for round/floor/ceil methods - Add docstring examples demonstrating Timedelta usage - Update parameter documentation to document Timedelta support - Add comprehensive test coverage with edge cases - Update whatsnew file with enhancement entry
randolf-scholz
force-pushed
the
timestamp_round_timedelta_main
branch
from
f76bce2 to
39fb56d
Compare
|
Did a rebase just now to fix the merge conflict, moving the whatsnew entry into 3.1.0 |
randolf-scholz
force-pushed
the
timestamp_round_timedelta_main
branch
from
cb01638 to
79c0182
Compare
|
minor comments, otherwise LGTM |
|
Can you address comments and merge main |
|
@randolf-scholz this is close to ready, are you planning to finish it? |
|
Sorry was really busy with other stuff I'll finish it tomorrow I think. |
|
@jbrockmendel I addressed the comments, the remaining CI failure seems unrelated, all recent PRs seem to trip on that check. (e.g. #65332, #65329) |
2 participants
Update type hints to accept str | Timedelta for round/floor/ceil methods
Add docstring examples demonstrating Timedelta usage
Update parameter documentation to document Timedelta support
Add comprehensive test coverage with edge cases
Update whatsnew file with enhancement entry
closes ENH:
Timestamp.round: officially acceptTimedeltaarguments #63687 (Replace xxxx with the GitHub issue number)Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.If I used AI to develop this pull request, I prompted it to follow
AGENTS.md.