Skip to content

BUG: Improve error message when ExtensionDtype subclass missing 'name' attribute #65299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avasis-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Improve error message when ExtensionDtype subclass missing 'name' attribute #65299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pandas/core/dtypes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,11 @@ def construct_from_string(cls, string: str) -> Self:
raise TypeError(
f"'construct_from_string' expects a string, got {type(string)}"
)
# error: Non-overlapping equality check (left operand type: "str", right
# operand type: "Callable[[ExtensionDtype], str]") [comparison-overlap]
assert isinstance(cls.name, str), (cls, type(cls.name))
if not isinstance(cls.name, str):
raise TypeError(
f"ExtensionDtype subclass {cls.__name__} must define a 'name' "
f"class attribute as a string, got {type(cls.name).__name__}"
)
if string != cls.name:
raise TypeError(f"Cannot construct a '{cls.__name__}' from '{string}'")
return cls()
Expand Down
Loading