BUG: fix ArrowExtensionArray constructor raising on np.nan in string sequences#65307
Open
tinezivic wants to merge 3 commits intopandas-dev:mainfrom
Open
BUG: fix ArrowExtensionArray constructor raising on np.nan in string sequences#65307tinezivic wants to merge 3 commits intopandas-dev:mainfrom
tinezivic wants to merge 3 commits intopandas-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
When constructing an
ArrowDtypestring array viapd.array()with a sequence that containsnp.nan, anArrowTypeErroris raised:Root cause
In
ArrowExtensionArray._box_pa_array(), the mask is computed via:np.asarray(["a", np.nan])produces a<U3Unicode array in whichnp.nanis silently coerced to the string'nan'.isna()then returns[False, False], the NA mask is empty, and pyarrow rejects the float value.Fix
Pass
dtype=objecttonp.asarray()so that scalar types are preserved andisna()correctly identifiesnp.nanas a missing value.Closes #64578