test: Various test fixes

[mtrezza]

Summary by CodeRabbit

• Chores

  • Updated configuration to ignore Visual Studio Code workspace settings in version control.
  • Enhanced test environment setup for improved reliability and cleanup during unit testing.

• Tests

  • Improved test cases to better simulate Android content resolution and environment setup, resulting in more accurate and consistent test behavior.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the .gitignore to exclude the .vscode directory, modify the Android Gradle build script to add JVM arguments for unit tests, and enhance several test classes to use Robolectric for better simulation of Android environments. Test setup and teardown methods were added, and URI handling in tests was improved with Robolectric's ShadowContentResolver.

Changes

Cohort / File(s)	Change Summary
Git Ignore Update .gitignore	Added the root-level /.vscode directory to the ignore list to prevent VS Code workspace settings from being tracked by Git.
Gradle Test JVM Arguments parse/build.gradle	Added JVM arguments to the testOptions.unitTests block to enable Byte Buddy experimental features and open specific Java modules for all unit tests.
Robolectric Test Enhancements: ParseCountingUriHttpBodyTest parse/src/test/java/com/parse/ParseCountingUriHttpBodyTest.java	Added Robolectric runner, setup, and teardown methods. Registered test URIs with Robolectric's ShadowContentResolver and refactored test data handling for consistency and integration with the simulated Android environment.
Robolectric Test Enhancements: ParseFileControllerTest parse/src/test/java/com/parse/ParseFileControllerTest.java	Improved test environment setup and teardown for the Parse SDK. In testSaveAsyncSuccessWithUri, registered the test URI with Robolectric's ShadowContentResolver to simulate content resolution.
Robolectric Test Enhancements: ParseUriHttpBodyTest parse/src/test/java/com/parse/ParseUriHttpBodyTest.java	Added Robolectric runner, setup, and teardown methods. Registered test URIs with Robolectric's ShadowContentResolver for accurate simulation of content resolution in tests.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner as Test Runner
    participant Robolectric as Robolectric Environment
    participant ShadowContentResolver as ShadowContentResolver
    participant ParseSDK as Parse SDK

    TestRunner->>Robolectric: Start test with @RunWith(RobolectricTestRunner)
    TestRunner->>ParseSDK: setUp() - Initialize Parse SDK
    TestRunner->>ShadowContentResolver: Register URI with InputStream
    TestRunner->>ParseSDK: Execute test logic (access URI)
    ParseSDK->>ShadowContentResolver: Resolve URI, get InputStream
    TestRunner->>ParseSDK: tearDown() - Reset and destroy Parse SDK

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6926f3 and 997ad57.

📒 Files selected for processing (5)

• .gitignore (1 hunks)
• parse/build.gradle (1 hunks)
• parse/src/test/java/com/parse/ParseCountingUriHttpBodyTest.java (3 hunks)
• parse/src/test/java/com/parse/ParseFileControllerTest.java (4 hunks)
• parse/src/test/java/com/parse/ParseUriHttpBodyTest.java (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Gradle Build

🔇 Additional comments (13)

.gitignore (1)

49-49: LGTM! Standard IDE exclusion added.

Adding /.vscode to .gitignore follows best practices by excluding Visual Studio Code workspace settings from version control.

parse/build.gradle (1)

18-27: Essential JVM arguments for Robolectric compatibility.

These JVM arguments are necessary for Robolectric to function properly:

• -Dnet.bytebuddy.experimental=true enables Byte Buddy experimental features required by Robolectric
• The --add-opens flags allow Robolectric to access internal Java modules, which is restricted by the Java module system in newer versions

parse/src/test/java/com/parse/ParseUriHttpBodyTest.java (4)

30-30: LGTM! Robolectric test runner properly configured.

The @RunWith(RobolectricTestRunner.class) annotation enables proper Android environment simulation for these tests.

---

34-54: Excellent test environment setup and cleanup.

The setUp() and tearDown() methods properly:

• Reset Parse plugins and core plugins before each test
• Initialize Parse SDK with test configuration using Robolectric's RuntimeEnvironment
• Clean up resources after each test to prevent test interference

---

63-68: Critical URI registration for content resolution simulation.

The ShadowContentResolver registration is essential for these tests to work properly. It associates the test URI with a ByteArrayInputStream, enabling the ParseUriHttpBody to read the expected content during testing.

---

84-88: Consistent URI registration pattern maintained.

The same URI registration approach is correctly applied in the second test method, ensuring consistent test behavior.

parse/src/test/java/com/parse/ParseFileControllerTest.java (3)

54-65: Proper Parse SDK initialization in test setup.

The setUp() method correctly initializes the Parse SDK environment using Robolectric's RuntimeEnvironment, ensuring tests run in a properly configured Android context.

---

73-75: Complete test cleanup with Parse.destroy().

The addition of Parse.destroy() in tearDown() ensures proper resource cleanup after each test, preventing potential test interference.

---

242-246: Essential URI registration for file upload testing.

The ShadowContentResolver registration enables the test to simulate content resolution from the URI, which is crucial for testing the file upload functionality with URI-based content.

parse/src/test/java/com/parse/ParseCountingUriHttpBodyTest.java (4)

35-35: Robolectric test runner properly configured.

The @RunWith(RobolectricTestRunner.class) annotation enables proper Android environment simulation for these URI-based tests.

---

40-60: Consistent Parse SDK setup and teardown.

The setUp() and tearDown() methods follow the same pattern as other test files, ensuring proper Parse SDK initialization and cleanup for isolated test execution.

---

84-88: Smart data consistency approach.

Using the testData variable for both ShadowContentResolver registration and assertion ensures data consistency and makes the test more maintainable.

Also applies to: 118-118

---

129-133: Consistent URI registration in exception test.

The same URI registration pattern is properly applied in the exception test, maintaining consistency across all test methods.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[parseplatformorg]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)