Skip to content

Delete from the cache on Get if the item expired (to trigger onEvicted) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fdurand wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Delete from the cache on Get if the item expired (to trigger onEvicted) #75

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1291d9
Delete from the cache on Get if the item expired (to trigger onEvicted)
fdurand Jan 3, 2018
cf0198a
Also added in GetWithExpiration
fdurand Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ func (c *cache) Get(k string) (interface{}, bool) {
if item.Expiration > 0 {
if time.Now().UnixNano() > item.Expiration {
c.mu.RUnlock()
c.Delete(k)

@moadqassem moadqassem Jan 4, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding this change also in the GetWithExpiration https://github.com/patrickmn/go-cache/pull/75/files#diff-56ffa6659747ba7a23d2b5597a4cda5dR143 ?

@fdurand fdurand Jan 4, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ekinanp ekinanp Mar 9, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll only want to call Delete if the cache has an eviction function.

return nil, false
}
}
Expand Down