Skip to content

fix autofocus #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedroSG94 merged 1 commit into from
Aug 3, 2026
Merged

fix autofocus #2166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions encoder/src/main/java/com/pedro/encoder/input/video/Camera2ApiManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,10 +688,18 @@ class Camera2ApiManager(context: Context) {
val builderInputSurface = this.builderInputSurface ?: return false
try {
if (supportedFocusModes.isNotEmpty()) {
//cancel any existing AF trigger
//cancel any existing AF trigger and clear the regions set by tapToFocus.
builderInputSurface.setTag("")
val maxRegionsAf = characteristics.secureGet(CameraCharacteristics.CONTROL_MAX_REGIONS_AF) ?: 0
if (maxRegionsAf > 0) {
val clearRect = MeteringRectangle(0, 0, 0, 0, MeteringRectangle.METERING_WEIGHT_DONT_CARE)
builderInputSurface.set(CaptureRequest.CONTROL_AF_REGIONS, arrayOf(clearRect))
}
builderInputSurface.set(CaptureRequest.CONTROL_AF_TRIGGER, CameraMetadata.CONTROL_AF_TRIGGER_CANCEL)
builderInputSurface.set(CaptureRequest.CONTROL_AF_MODE, CaptureRequest.CONTROL_AF_MODE_OFF)
applyRequest(builderInputSurface)
runCatching {
cameraCaptureSession?.capture(builderInputSurface.build(), null, null)
}.onFailure { Log.e(TAG, "Error", it) }
// Prefer CONTINUOUS_VIDEO: same smooth AF as CONTINUOUS_PICTURE but defers
// fine adjustments to not interrupt frame delivery (no dropped frames on focus hunt).
if (supportedFocusModes.contains(CaptureRequest.CONTROL_AF_MODE_CONTINUOUS_VIDEO)) {
Expand All @@ -707,6 +715,7 @@ class Camera2ApiManager(context: Context) {
builderInputSurface.set(CaptureRequest.CONTROL_AF_MODE, supportedFocusModes[0])
isAutoFocusEnabled = false
}
builderInputSurface.set(CaptureRequest.CONTROL_AF_TRIGGER, CameraMetadata.CONTROL_AF_TRIGGER_IDLE)
applyRequest(builderInputSurface)
}
result = isAutoFocusEnabled
Expand All @@ -718,23 +727,20 @@ class Camera2ApiManager(context: Context) {
}

fun disableAutoFocus(): Boolean {
val result = false
val characteristics = cameraCharacteristics ?: return false
val builderInputSurface = this.builderInputSurface ?: return false
val supportedFocusModes = characteristics.secureGet(CameraCharacteristics.CONTROL_AF_AVAILABLE_MODES) ?: return false
for (mode in supportedFocusModes) {
try {
runCatching {
if (mode == CaptureRequest.CONTROL_AF_MODE_OFF) {
builderInputSurface.set(CaptureRequest.CONTROL_AF_MODE, CaptureRequest.CONTROL_AF_MODE_OFF)
applyRequest(builderInputSurface)
isAutoFocusEnabled = false
return true
}
} catch (e: Exception) {
Log.e(TAG, "Error", e)
}
}.onFailure { Log.e(TAG, "Error", it) }
}
return result
return false
}

fun enableFaceDetection(faceDetectorCallback: FaceDetectorCallback?): Boolean {
Expand Down
Loading