Skip to content

Brittle deduplication test cases #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
orangejulius wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Brittle deduplication test cases #557

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29ef568
Add Geonames NYC test case
orangejulius Mar 2, 2022
c3bad19
Add Berlin deduplication test
orangejulius Mar 2, 2022
99793d4
Use city name instead of township
orangejulius Mar 2, 2022
1783562
Add Specific Berlin geonames record
orangejulius Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 61 additions & 2 deletions test_cases/deduplication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
"name": "Pennsylvania",
"layer": "region"
}, {
"name": "Pennsylvania Township",
"layer": "localadmin",
"name": "Pennsylvania",
"layer": "locality",
"region": "Illinois"
}]
}
Expand Down Expand Up @@ -103,6 +103,65 @@
}
]
}
},
{
"id": 5,
"status": "fail",
"user": "orangejulius",
"endpoint": "autocomplete",
"description": "Geonames 'New York City' record should not appear",
"in": {
"text": "New York"
},
"expected": {
"properties": [
{
"name": "New York",
"layer": "locality"
}
]
},
"unexpected": {
"properties": [
{
"name": "New York City"
}
]
}
},
{
"id": 6,
"status": "fail",
"user": "orangejulius",
"endpoint": "autocomplete",
"description": "Multiple Berlin records should not appear",
"in": {
"text": "Berlin"
},
"expected": {
"properties": [
{
"name": "Berlin",
"layer": "locality"
}
]
},
"unexpected": {
"properties": [
{
"name": "Berlin",
"gid": "geonames:locality:6547383"
},
{
"name": "Berlin",
"layer": "region"
},
{
"name": "Berlin",
"layer": "localadmin"
}
]
}
}
]
}