Skip to content

feat(0000): update package versions (#1)#13

Closed
heons wants to merge 0 commit into
pelias:masterfrom
heons:master
Closed

feat(0000): update package versions (#1)#13
heons wants to merge 0 commit into
pelias:masterfrom
heons:master

Conversation

@heons

@heons heons commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.


Here's the reason for this change 🚀

It is the follow up PR of pelias/config#147
To remove the deprecation warnings during the package install by replacing deprecated @hapi/joi with a direct replacement of it;joi. It is from the two pealis packages. pelias-config and pelias-model.


Here's what actually got changed 👏

  • through2: ^3.0.1 → ^4.0.2
  • pelias-config: ^4.1.0 → ^6.2.0
  • pelias-model: ^7.0.0 → ^10.6.0
  • jshint: ^2.9.6 → ^2.13.6
  • node engine: >=10.0.0 → >=14.0.0

Here's how others can test the changes 👀

Verification: 18/18 tests passing, lint clean, dependency tree clean.

@heons heons marked this pull request as ready for review June 3, 2026 18:05
@orangejulius

Copy link
Copy Markdown
Member

Nice thanks. Can you change the chore() in the commit message to feat()? otherwise, our CI won't publish a new package.

BTW we're about to go through the annual process of bumping Node.js versions everywhere now that Node.js 20 is EOL and Node 26 is out. We have some scripts that will catch out of date pelias dependencies, but obviously we've missed running them in some places :P

Also we're considering removing through2 in favor of just the built in Node.js stream classes. It's gotten a lot easier to work with streams than when we started Pelias in 2013!

@heons heons changed the title chore(0000): update package versions (#1) feat(0000): update package versions (#1) Jun 4, 2026
@heons

heons commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@orangejulius Thank you for reviewing!

  • I updated the title to feat()
  • Yes. Replacing through2 with built-in Node.js stream classes makes sense!.

@orangejulius

Copy link
Copy Markdown
Member

Merged in #2, I had to change the actual commit message as well, not just the PR title. I always get the "push to a contributor's branch" workflow wrong so ended up closing this one 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants