Feat: ReplSet and Cluster data sizes#5416
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5416 +/- ##
==========================================
- Coverage 43.53% 43.50% -0.03%
==========================================
Files 413 543 +130
Lines 42943 45115 +2172
Branches 0 590 +590
==========================================
+ Hits 18694 19626 +932
- Misses 22376 23552 +1176
- Partials 1873 1937 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds “Total Data Size” visibility to MongoDB ReplSet and Cluster Summary dashboards (and corresponding docs) by calculating total logical size from MongoDB exporter dbstats metrics.
Changes:
- Add new “Total Data Size” stat panel and “Data Size Over Time” timeseries panel to ReplSet Summary.
- Add new “Total Data Size” stat panel and “Data Size Over Time” timeseries panel to Cluster Summary.
- Document the new panels and their dependency on enabling the exporter
dbstatscollector.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| documentation/docs/reference/dashboards/dashboard-mongodb-replset-summary.md | Documents new ReplSet “Total Data Size” panel and requirements. |
| documentation/docs/reference/dashboards/dashboard-mongodb-cluster-summary.md | Documents new Cluster “Total Data Size” panel and requirements. |
| dashboards/dashboards/MongoDB/MongoDB_ReplSet_Summary.json | Adds new data size panels; adjusts layout; updates rs_nm templating behavior and some dashboard links. |
| dashboards/dashboards/MongoDB/MongoDB_Cluster_Summary.json | Adds new data size panels; adjusts layout; updates some dashboard links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dba45b2 to
a49b630
Compare
| "step": 300 | ||
| } | ||
| ], | ||
| "title": "Total Data Size", |
There was a problem hiding this comment.
@catalinaadam I think we should be using Sentence case here (and other places legends/panel titles/etc.) right?
There was a problem hiding this comment.
I just checked and both dashboards use Title Case in their panels, e.g.:
Memory UsedDisk Space UtilizationOplog Recovery WindowOplog Processing Time- ...
Same happens in other dashboards across Mongo, MySQL and PG
There was a problem hiding this comment.
I think at the moment yes, but I think we wanted to move more into using Sentence case if I remember (there's a google doc with some recomendations)
There was a problem hiding this comment.
@matejkubinec, indeed sentence case is the standard we want to move to. However, changing just these two panels while all other panels on these dashboards still use title case would create inconsistency within the same dashboard. Can we standardize capitalization across all panels as part of PMM-14999?
catalinaadam
left a comment
There was a problem hiding this comment.
Added release notes with dd85f68
| "step": 300 | ||
| } | ||
| ], | ||
| "title": "Total Data Size", |
There was a problem hiding this comment.
@matejkubinec, indeed sentence case is the standard we want to move to. However, changing just these two panels while all other panels on these dashboards still use title case would create inconsistency within the same dashboard. Can we standardize capitalization across all panels as part of PMM-14999?
Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com>
Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com>
Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com>
Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com>
…set-summary.md Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com>
…ter-summary.md Co-authored-by: Catalina A <94133018+catalinaadam@users.noreply.github.com>
PMM-13306
Using
mongodb_dbstats_dataSizeandmongodb_dbstats_indexSizeto calculate metrics.@igroene Please let us know if this sounds accurate or if there's a better way, as I'm no expert at this.