Skip to content

PMM-15146 prevent non official telemetry#5505

Open
4nte wants to merge 6 commits into
mainfrom
PMM-15146-prevent-non-official-telemetry
Open

PMM-15146 prevent non official telemetry#5505
4nte wants to merge 6 commits into
mainfrom
PMM-15146-prevent-non-official-telemetry

Conversation

@4nte

@4nte 4nte commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

PMM-15146

Percona-Lab/pmm-submodules#4412

See related PR in our build pipeline: Percona-Lab/jenkins-pipelines#4205

Telemetry destination is now controlled by where the build points, a default address has been replaced with a non-prod address to prevent non-official builds from polluting prod telemetry.

  • Unofficial and non RC/GA builds (local dev, forks, feature builds) default to https://check-dev.percona.com
  • Official RC/GA images bake https://check.percona.com via the env var PMM_DEV_PERCONA_PLATFORM_ADDRESS.
  • The runtime telemetry on/off toggle (UI/Settings) keeps working in all builds.

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.36%. Comparing base (518b072) to head (26e2e21).
⚠️ Report is 1372 commits behind head on main.

Files with missing lines Patch % Lines
managed/utils/envvars/parser.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5505      +/-   ##
==========================================
+ Coverage   42.07%   43.36%   +1.28%     
==========================================
  Files         399      543     +144     
  Lines       50719    45303    -5416     
  Branches        0      590     +590     
==========================================
- Hits        21340    19645    -1695     
+ Misses      27370    23716    -3654     
+ Partials     2009     1942      -67     
Flag Coverage Δ
admin 34.78% <ø> (+23.23%) ⬆️
agent 48.93% <ø> (-3.05%) ⬇️
managed 42.83% <0.00%> (+0.03%) ⬆️
unittests 41.31% <ø> (?)
vmproxy 72.22% <ø> (+3.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@4nte 4nte marked this pull request as ready for review June 17, 2026 07:26
@4nte 4nte requested a review from a team as a code owner June 17, 2026 07:26
@4nte 4nte requested review from JiriCtvrtka and maxkondr and removed request for a team June 17, 2026 07:26
Comment thread build/docker/server/Dockerfile.el9 Outdated
ENV GF_PLUGIN_DIR=/srv/grafana/plugins
ENV PERCONA_TELEMETRY_DISABLE=1
ENV PS1="[\u@\h \W] # "
ENV PMM_DEV_PERCONA_PLATFORM_ADDRESS=${PMM_DEV_PERCONA_PLATFORM_ADDRESS}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4nte I'm wondering if it's a good idea to have a DEV variable in the release image 🤔 It looks like we may have to rename it to PMM_PERCONA_PLATFORM_ADDRESS.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, env var has been renamed.

@ademidoff ademidoff requested review from a team and Nailya as code owners June 17, 2026 20:14
@ademidoff ademidoff requested review from fabio-silva and mattiasimonato and removed request for a team June 17, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants