PMM-15095: adopt percona-ui navigable rows hooks in RTA overview#5506
Open
mattiasimonato wants to merge 9 commits into
Open
PMM-15095: adopt percona-ui navigable rows hooks in RTA overview#5506mattiasimonato wants to merge 9 commits into
mattiasimonato wants to merge 9 commits into
Conversation
mattiasimonato
requested review from
fabio-silva and
matejkubinec
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the RTA (Real-Time Analytics) overview page to use shared navigation/table hooks from @percona/percona-ui, removing locally maintained glue code while preserving the existing “details pane arrows follow filtered/sorted table rows” behavior introduced previously.
Changes:
- Refactors
OverviewTableto useuseNavigableRowsfor syncing the navigable (filtered/sorted) row set. - Refactors
RealtimeOverviewto useuseDetailsPaneNavigationfor prev/next/first/last details-pane navigation state and actions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx | Replaces hand-rolled MRT state/ref wiring with useNavigableRows, and triggers refresh before selecting a hovered row. |
| ui/apps/pmm/src/pages/rta/overview/RealtimeOverview.tsx | Replaces manual index-based adjacent navigation with useDetailsPaneNavigation and passes its outputs to DetailsPane. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@mattiasimonato please apply percona-ui@1.0.22, we had a bug after upgrading MRT |
fabio-silva
approved these changes
Jun 18, 2026
matejkubinec
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number: PMM-15095
Feature build: SUBMODULES-4414
OverviewTablewithuseNavigableRowsfrom@percona/percona-uiRealtimeOverviewwithuseDetailsPaneNavigationfrom@percona/percona-uiThis refactor keeps the same RTA overview behavior introduced in #5397 (details pane arrows respect table filters and sort order) while removing duplicated glue code now shared upstream in percona-ui.