Skip to content

PMM-14895 Replace usage of Master with Primary in Valkey dashboards #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matejkubinec wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PMM-14895 Replace usage of Master with Primary in Valkey dashboards #5507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbdeae7
PMM-14895 Replace usage of Master with Primary in Valkey dashboards
matejkubinec Jun 17, 2026
7af15b2
Merge branch 'main' into PMM-14895-valkey-terminology
matejkubinec Jun 18, 2026
98ed3d5
Merge branch 'main' into PMM-14895-valkey-terminology
matejkubinec Jun 18, 2026
91cb78e
Merge branch 'main' into PMM-14895-valkey-terminology
matejkubinec Jun 18, 2026
6f67cfd
Merge branch 'main' into PMM-14895-valkey-terminology
matejkubinec Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile.devcontainer
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ run-all: run-agent-ci run-managed-ci run-qan-ci run-vmproxy-ci ## Run all go ser
run: run-all ## Aliased to "run-all"
echo "run is aliased to run-all"

reload-dashboards:
rm -r /usr/share/percona-dashboards/panels/pmm-app/dist/dashboards
cp -r /root/go/src/github.com/percona/pmm/dashboards/dashboards /usr/share/percona-dashboards/panels/pmm-app/dist/dashboards
supervisorctl restart grafana

# TODO https://jira.percona.com/browse/PMM-3484, see maincover_test.go
# run-race-cover: install-race ## Run pmm-managed with race detector and collect coverage information.
# go test -coverpkg="github.com/percona/pmm/managed/..." \
Expand Down
2 changes: 1 addition & 1 deletion dashboards/dashboards/Valkey/Valkey_ClusterDetails.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@
"refId": "M"
}
],
"title": "$service_name - Replica vs Master offsets",
"title": "$service_name - Replica vs Primary offsets",
"type": "timeseries"
},
{
Expand Down
6 changes: 3 additions & 3 deletions dashboards/dashboards/Valkey/Valkey_PersistenceDetails.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"id": 60,
"panels": [],
"title": "Master AOF Persistence ",
"title": "Primary AOF Persistence ",
"type": "row"
},
{
Expand Down Expand Up @@ -785,7 +785,7 @@
"properties": [
{
"id": "displayName",
"value": "Master offset"
"value": "Primary offset"
}
]
},
Expand Down Expand Up @@ -871,7 +871,7 @@
},
"id": 75,
"panels": [],
"title": "Master RDB persistence",
"title": "Primary RDB persistence",
"type": "row"
},
{
Expand Down
2 changes: 1 addition & 1 deletion dashboards/dashboards/Valkey/Valkey_Replication.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@
"useBackend": false
}
],
"title": "$service_name - Replica vs Master Offsets",
"title": "$service_name - Replica vs Primary offsets",
"type": "timeseries"
},
{
Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/reference/dashboards/dashboard-valkey-redis-cluster-details.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Sudden role changes may indicate planned failovers, automatic failover due to pr

## Replication Offsets

### [Service name] - Replica vs Master Offsets
### [Service name] - Replica vs Primary offsets

Displays the replication offset difference between primary nodes and their replicas, measured in bytes.

Expand Down
2 changes: 1 addition & 1 deletion documentation/docs/reference/dashboards/dashboard-valkey-redis-replication.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The timeline view shows historical role states, helping correlate role changes w

## Replication Offsets

### [Replica service name] - Replica vs Master offsets
### [Replica service name] - Replica vs Primary offsets

Displays replication offsets in bytes for both primary and replica nodes, showing how current each replica is with the primary's write operations.

Expand Down
Loading