Skip to content

Add support for setting Strict Outgoing Network Interface Binding (strictout) #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mart1n-anders wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add support for setting Strict Outgoing Network Interface Binding (strictout) #254

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6de611e
Add support for setting strict outgoing network interface binding
mart1n-anders Apr 2, 2026
cc4dd17
Add strictout to test file
mart1n-anders Apr 2, 2026
3ed0d5c
Add version_added to strictout
mart1n-anders Apr 9, 2026
1e48df8
Update CHANGELOG.rst with v0.7.2
mart1n-anders Apr 9, 2026
89e451a
Remove trailing space
mart1n-anders Apr 15, 2026
e3f9350
Remove changelog entry
mart1n-anders Apr 15, 2026
5140bb9
Update CHANGELOG.rst
mart1n-anders Apr 15, 2026
b85e188
Create changelog fragment
mart1n-anders Apr 15, 2026
ff91eb3
No default value for strictout
mart1n-anders Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions plugins/modules/pfsense_dns_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,13 @@
default: [ "all" ]
type: list
elements: str
strictout:
description:
Comment thread
opoplawski marked this conversation as resolved.
Outdated
- Strict Outgoing Network Interface Binding.
- Do not send recursive queries if none of the Outgoing Network Interfaces are available.
required: false
default: false
type: bool
Comment thread
opoplawski marked this conversation as resolved.
system_domain_local_zone_type:
description: The local-zone type used for the pfSense system domain.
required: false
Expand Down Expand Up @@ -338,7 +345,7 @@
tlsport=dict(default=None, type='int'),
active_interface=dict(default=["all"], type='list', elements='str'),
outgoing_interface=dict(default=["all"], type='list', elements='str'),
# TODO: Strict Outgoing Network interface Binding: check box option
strictout=dict(default=False, type='bool'),
Comment thread
mart1n-anders marked this conversation as resolved.
Outdated
system_domain_local_zone_type=dict(default='transparent', choices=['deny', 'refuse', 'static', 'transparent', 'typetransparent', 'redirect', 'inform',
'inform_deny', 'nodefault']),
dnssec=dict(default=True, type='bool'),
Expand Down Expand Up @@ -455,6 +462,7 @@ def _params_to_obj(self):
self._get_ansible_param_bool(obj, "forward_tls_upstream", value="")
self._get_ansible_param_bool(obj, "prefetch", value="")
self._get_ansible_param_bool(obj, "prefetchkey", value="")
self._get_ansible_param_bool(obj, "strictout", value="")
self._get_ansible_param(obj, "msgcachesize")
self._get_ansible_param(obj, "outgoing_num_tcp")
self._get_ansible_param(obj, "incoming_num_tcp")
Expand Down Expand Up @@ -524,7 +532,7 @@ def _get_params_to_remove(self):
return ["enable"]
else:
return ["hideidentity", "hideversion", "dnssecstripped", "forwarding", "regdhcp", "regdhcpstatic", "regovpnclients", "enablessl", "dnssec",
"forward_tls_upstream", "prefetch", "prefetchkey"]
"forward_tls_upstream", "prefetch", "prefetchkey", "strictout"]

##############################
# run
Expand Down Expand Up @@ -564,6 +572,7 @@ def _log_fields(self, before=None):
values += self.format_updated_cli_field(self.obj, before, 'tlsport', fvalue=self.fvalue_bool, add_comma=(values), log_none=False)
values += self.format_updated_cli_field(self.obj, before, 'sslcertref', fvalue=self.fvalue_bool, add_comma=(values), log_none=False)
values += self.format_updated_cli_field(self.obj, before, 'forwarding', fvalue=self.fvalue_bool, add_comma=(values), log_none=False)
values += self.format_updated_cli_field(self.obj, before, 'strictout', fvalue=self.fvalue_bool, add_comma=(values), log_none=False)
values += self.format_updated_cli_field(self.obj, before, 'system_domain_local_zone_type', add_comma=(values), log_none=False)
values += self.format_updated_cli_field(self.obj, before, 'regdhcp', fvalue=self.fvalue_bool, add_comma=(values), log_none=False)
values += self.format_updated_cli_field(self.obj, before, 'regdhcpstatic', fvalue=self.fvalue_bool, add_comma=(values), log_none=False)
Expand Down
1 change: 1 addition & 0 deletions tests/unit/plugins/modules/test_pfsense_dns_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def check_target_elt(self, obj, target_elt, target_idx=-1):
# self.check_param_equal(obj, target_elt, 'active_interface')
# self.check_param_equal(obj, target_elt, 'outgoing_interface')
# self.check_param_equal(obj, target_elt, 'system_domain_local_zone_type')
self.check_param_bool(obj, target_elt, 'strictout', default=False)
self.check_param_bool(obj, target_elt, 'dnssec', default=True)
self.check_param_bool(obj, target_elt, 'forwarding')
self.check_param_bool(obj, target_elt, 'forward_tls_upstream')
Expand Down
Loading