fix(client): fall back to defaults when preset storage is corrupt

[jeffrey701]

Problem

loadPresets (client/src/services/presets.ts) is the only localStorage loader in the module that calls JSON.parse without a try/catch:

const saved = JSON.parse(raw) as GamePreset[];
return saved.length > 0 ? saved : DEFAULT_PRESETS;

Every sibling loader (loadActiveGame, loadWsSession, loadActiveQuickDraft, …) wraps the parse and returns a fallback. So a corrupt/partial phase-game-presets value (e.g. a write interrupted mid-flush, or an older schema) throws a SyntaxError. And because savePreset and deletePreset both call loadPresets() first, all three throw — the game-setup preset UI crashes rather than recovering.

Fix

Wrap the parse in try/catch and fall back to DEFAULT_PRESETS, matching the other loaders.

Tests

Adds presets.test.ts: corrupt storage ("{oops") makes loadPresets / savePreset / deletePreset throw before the fix and return/no-throw after; empty storage yields the defaults; valid storage round-trips a saved preset.

Self-contained: only presets.ts + a new test; no engine/Rust/protocol changes.

Model: claude-opus-4-8

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[matthewevans]

Deferred by maintainer intake policy — not ignored.

This current head (d059c301951e910370a2a2ba0f43ddbfbff37888) was triaged as a frontend-only change (client/src/services/__tests__/presets.test.ts, client/src/services/presets.ts) by jeffrey701. The local frontend-review allowlist does not include this author, so this route does not perform an implementation-diff review or approve the PR.

A maintainer must explicitly take this PR or add a local frontend-review exception before it can receive substantive review. The defer label is a routing marker only, not a verdict on the change.

[matthewevans]

Deferred by maintainer intake policy — not ignored.

This current head (d059c301951e910370a2a2ba0f43ddbfbff37888) was triaged as a frontend-only change (client/src/services/__tests__/presets.test.ts, client/src/services/presets.ts) by jeffrey701. The local frontend-review allowlist does not include this author, so this route does not perform an implementation-diff review or approve the PR.

A maintainer must explicitly take this PR or add a local frontend-review exception before it can receive substantive review. The defer label is a routing marker only, not a verdict on the change.

[matthewevans]

Deferred by maintainer intake policy — not ignored.

This current head (d059c301951e910370a2a2ba0f43ddbfbff37888) was triaged as a frontend-only change (client/src/services/__tests__/presets.test.ts, client/src/services/presets.ts) by jeffrey701. The local frontend-review allowlist does not include this author, so this route does not perform an implementation-diff review or approve the PR.

A maintainer must explicitly take this PR or add a local frontend-review exception before it can receive substantive review. The defer label is a routing marker only, not a verdict on the change.

[matthewevans]

Deferred by maintainer intake policy — not ignored.

This current head (d059c301951e910370a2a2ba0f43ddbfbff37888) was triaged as a frontend-only change (client/src/services/__tests__/presets.test.ts, client/src/services/presets.ts) by jeffrey701. The local frontend-review allowlist does not include this author, so this route does not perform an implementation-diff review or approve the PR.

A maintainer must explicitly take this PR or add a local frontend-review exception before it can receive substantive review. The defer label is a routing marker only, not a verdict on the change.