Remove peppol-commons dependency on ph-bc - #81
Draft
gregjotau wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on phax/ph-commons#57 and is intentionally a draft until that change is released as ph-commons 12.3.6.
What this changes
ph-bcdependency frompeppol-commons; production source has no BC orph-bcreferences.ph-commons-parent-pom12.3.6-SNAPSHOT so this can be tested against the provider-neutralph-securitychange. I will replace this with the released 12.3.6 version before marking the PR ready.ph-bcis on the test/runtime classpath while all Peppol AP and SMP G3 trust anchors initialize correctly.Verification
mvn -pl peppol-commons verify— 30 tests, 0 failures/errors (2 existing skips).org.bouncycastleartifacts andcom.helger.commons:ph-bcis empty.PeppolTrustedCA.peppolAllAP()andpeppolAllSMP()and checks both expected trust anchors in each store.This is the small downstream follow-up needed after phax/ph-commons#57; phase4 already made its own direct
ph-bcdependency optional in phase4 4.6.1.