Skip to content

Remove peppol-commons dependency on ph-bc - #81

Merged
phax merged 1 commit into
phax:masterfrom
gregjotau:contribution/remove-ph-bc-dependency
Aug 30, 2026
Merged

Remove peppol-commons dependency on ph-bc#81
phax merged 1 commit into
phax:masterfrom
gregjotau:contribution/remove-ph-bc-dependency

Conversation

@gregjotau

@gregjotau gregjotau commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

What this changes

  • Removes the direct ph-bc dependency from peppol-commons; production source has no BC or ph-bc references.
  • Uses the provider-neutral ph-security from the released ph-commons 12.4.0 already imported by current master.
  • Adds a regression test proving that neither Bouncy Castle nor ph-bc is on the test/runtime classpath while all Peppol AP and SMP G3 trust anchors initialize correctly.

Verification

  • Rebased onto current peppol-commons master (12.9.1-SNAPSHOT).
  • mvn -pl peppol-commons verify — 30 tests, 0 failures/errors (2 existing skips).
  • Runtime dependency-tree filter for all org.bouncycastle artifacts, com.helger.commons:ph-bc, and org.cryptacular:cryptacular is empty.
  • The regression test initializes both PeppolTrustedCA.peppolAllAP() and peppolAllSMP() and checks both expected trust anchors in each store.

The prerequisite provider-neutral ph-security change was merged in phax/ph-commons#57 and released in ph-commons 12.4.0. Phase4 already made its direct ph-bc dependency optional in 4.6.1.

@gregjotau
gregjotau force-pushed the contribution/remove-ph-bc-dependency branch from 23a89fe to ae9714f Compare August 30, 2026 13:15
@gregjotau
gregjotau marked this pull request as ready for review August 30, 2026 13:15
@phax
phax merged commit 31cd9bd into phax:master Aug 30, 2026
1 check passed
@phax

phax commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Sorry I missed this one :(
Thanks for the efforts

@gregjotau
gregjotau deleted the contribution/remove-ph-bc-dependency branch August 30, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants