chore: bump actions/setup-node and actions/cache pins in setup composite action - #84
Merged
Merged
Conversation
…ite action actions/setup-node@v4 -> v7 and actions/cache@v4 -> v6 in .github/actions/setup/action.yml, the shared composite action used by validate.yml and regularCheck.yml. Dependabot's github-actions updater does not scan composite action files outside .github/workflows/, so these pins were stuck 3 and 2 majors behind respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/actions/setup/action.yml— the shared composite "Setup" action used by every job invalidate.ymlandregularCheck.yml— pinnedactions/setup-node@v4(3 majors behindv7) andactions/cache@v4(2 majors behindv6). Dependabot'sgithub-actionsecosystem updater only scansuses:pins inside.github/workflows/*.yml, not composite action definitions under.github/actions/**, so these two pins were a blind spot never touched by the two currently-open Dependabot PRs (#71 bumpsactions/cacheonly inside the two workflow files; #72 bumpsactions/checkoutonly inside the two workflow files).Solution
Bump both pins in
.github/actions/setup/action.ymlto their current major release, confirmed via the GitHub releases API:actions/setup-node@v4→actions/setup-node@v7(latest: v7.0.0)actions/cache@v4→actions/cache@v6(latest: v6.1.0)No other files changed — the
actions/cache@v4pins insideregularCheck.yml/validate.yml's "Cache embedding model" steps are already covered by open PR #71 and are out of scope here, as isactions/checkout(PR #72).Verification
This is a pin-only change with no application code touched.
npm ciin this sandbox fails on an unrelated, pre-existing issue (onnxruntime-node's postinstall script needsapi.nuget.org, which the sandbox network doesn't allow), so I could not runnpm run test/lint/typecheck locally end-to-end. I did confirm:uses:pins.v7.0.0andv6.1.0are genuinely the latest releases ofactions/setup-nodeandactions/cacherespectively (checked via the GitHub releases API).This PR's own CI run of
validate.yml/regularCheck.yml(which consume this composite action viauses: ./.github/actions/setup) is the real verification thatnpm ci, typecheck, lint, format check, andnpm run teststill pass — please check that the checks are green before merging, since I could not confirm it locally.Closes #83
Note
Low Risk
Pin-only CI dependency updates with no application or auth changes. Residual risk is a possible cache/setup-node behavior change on CI until the workflows run green.
Overview
Bumps GitHub Action majors in the shared composite Setup action used by
validate.ymlandregularCheck.yml:actions/setup-nodefrom v4 to v7 andactions/cachefrom v4 to v6.No workflow or application logic changes. Workflow-level
actions/cachepins for the embedding-model cache remain at v4.Reviewed by Cursor Bugbot for commit 1d36161. Bugbot is set up for automated code reviews on this repo. Configure here.