Skip to content

fix(blocks): treat a malformed blocks/latest response as a failed poll #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2xburnt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(blocks): treat a malformed blocks/latest response as a failed poll #688

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f03fbac
fix(blocks): treat a malformed blocks/latest response as a failed poll
2xburnt Jul 24, 2026
3950bf6
fix(blocks): require chain_id as well as height in the payload guard
2xburnt Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/stores/useBaseStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ export const useBaseStore = defineStore('baseStore', {
async fetchLatest() {
if (!this.hasRpc) return this.latest;
try {
this.latest = await this.blockchain.rpc?.getBaseBlockLatest();
const latest = await this.blockchain.rpc?.getBaseBlockLatest();
// A malformed 200 (an error body, a rate-limit page) would otherwise be
// stored as `latest`; its missing chain_id then trips the reset below and
// wipes earliest/recents, resetting the average block time to the 1000ms
// placeholder. Treat it as a failed poll instead.
if (!latest?.block?.header?.height) throw new Error('malformed blocks/latest payload');
Comment thread
2xburnt marked this conversation as resolved.
Outdated
this.latest = latest;
this.connected = true;
} catch (error) {
console.error('Error fetching latest block:', error);
Expand Down
Loading