Feat/account copy qr - #695
Conversation
Let users copy account and transaction hashes and open a QR dialog for the account address. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd7b57bf0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <table class="table w-full text-sm"> | ||
| <tbody> | ||
| <template v-for="(value, key) in account" :key="key"> | ||
| <template v-if="key === 'pub_key' && value && typeof value === 'object'"> |
There was a problem hiding this comment.
When the account uses a multisig public key, pub_key is an object with fields such as threshold and public_keys, rather than a scalar key. This branch intercepts every object-valued pub_key, so those fields are no longer rendered by DynamicComponent; the page instead displays a blank key and the copy action writes undefined. Restrict this layout to public-key types that actually contain key, and retain the generic rendering path for other key structures.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed — the specialized pubkey/copy layout now only applies when pub_key has a string key. Multisig and other structured keys fall through to DynamicComponent again.
Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
This pull request enhances the account details page by adding convenient copy-to-clipboard features for addresses, public keys, and transaction hashes, as well as a modal to display the account address as a QR code. It also improves the UI for better accessibility and user experience.
UI/UX Improvements:
DynamicComponentwith a table layout, including inline copy buttons for both the address and public key. (src/modules/[chain]/account/[address].vueL537-R674)Copy-to-Clipboard Functionality:
Accessibility Enhancements:
These changes collectively make it easier for users to interact with and share key account information, while also improving accessibility and the overall user experience.