Skip to content

docs: clarify max-ts max-drift constraint#21761

Closed
ekexium wants to merge 2 commits into
pingcap:masterfrom
ekexium:avery/max-ts-max-drift-master
Closed

docs: clarify max-ts max-drift constraint#21761
ekexium wants to merge 2 commits into
pingcap:masterfrom
ekexium:avery/max-ts-max-drift-master

Conversation

@ekexium

@ekexium ekexium commented Jul 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Clarify that storage.max-ts.max-drift must be greater than cache-sync-interval, otherwise TiKV rejects the configuration.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: Ziqian Qin <eke@fastmail.com>
Copilot AI review requested due to automatic review settings July 3, 2026 06:22
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign icemap for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Clarifies the TiKV storage.max-ts.max-drift configuration constraint to prevent invalid configurations (where max-drift is not greater than cache-sync-interval) from being used.

Changes:

  • Document that storage.max-ts.max-drift must be greater than storage.max-ts.cache-sync-interval, otherwise TiKV rejects loading the configuration.
  • Keep the existing recommendation to set max-drift to at least 3× cache-sync-interval.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ekexium ekexium requested a review from qiancai July 3, 2026 06:24
Signed-off-by: Ziqian Qin <eke@fastmail.com>
@ekexium ekexium closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants