planner: fix TPCDS Q64 regression under the new join algorithm#69637
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe greedy join-order optimizer now uses a stable sort for equal-cost candidates, and the TPCDS Q64 expected plan outputs were updated to match the resulting join and exchange ordering. ChangesJoin Order Sort Stability and Q64 Plan Expectations
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69637 +/- ##
================================================
- Coverage 76.3268% 74.1110% -2.2159%
================================================
Files 2041 2050 +9
Lines 560589 576524 +15935
================================================
- Hits 427880 427268 -612
- Misses 131808 149049 +17241
+ Partials 901 207 -694
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #69600
Problem Summary: planner: fix TPCDS Q64 regression under the new CD-C join algorithm
What changed and how does it work?
In TPCDS Q64,
ib1andib2have the same row count, but the old join-order implementation is usingSortStableFuncwhile the new one is usingSortFunc, which leads to this join order change.This PR update the new join-order implementation to also use
SortStableFuncto keep the prior behavior.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit