Skip to content

test: stabilize flaky TestImportInto#69644

Open
flaky-claw wants to merge 1 commit into
pingcap:masterfrom
flaky-claw:flakyfixer/case_21dc6f426b0e-a1
Open

test: stabilize flaky TestImportInto#69644
flaky-claw wants to merge 1 commit into
pingcap:masterfrom
flaky-claw:flakyfixer/case_21dc6f426b0e-a1

Conversation

@flaky-claw

@flaky-claw flaky-claw commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #69622

Problem Summary:
Flaky test TestImportInto in tests/realtikvtest/importintotest4 intermittently fails, so this PR stabilizes that path.

What changed and how does it work?

Root Cause

Fixed-port fake GCS setup could collide under concurrent RealTiKV execution before TestImportInto reached import assertions.

Fix

Binding to port 0 gives each suite run exclusive listener ownership while preserving the same fake GCS endpoint semantics.

Verification

Spec:

  • target: tests/realtikvtest/importintotest4 :: TestImportInto
  • strategy: tidb.issue_scoped.v2
  • plan mode: BASELINE_ONLY
  • requirements: required case must execute; no skip; repeat count = 1
  • execution surface: GO_TEST_WITH_TAGS
  • build tags: intest, deadlock
  • baseline gates: required_flaky_gate, build_safety_gate, intent_guard_gate
  • feedback surface source: baseline_only

Observed result:

  • status: failed
  • required case executed: yes
  • submission decision: ALLOWED
  • note: Required flaky case executed during validation.
    Required flaky case was not skipped.

Gate checklist:

  • native_contract_target: FAIL
  • failpoint_target_local: SKIPPED
  • package_failpoint_local: SKIPPED
  • build: BLOCKED
  • lint: SKIPPED

Commands:

  • go test -json -tags=intest,deadlock ./tests/realtikvtest/importintotest4 -run '^TestImportInto$' -count=1

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Fixes #69622

Summary by CodeRabbit

  • Tests
    • Updated the test setup to use the storage server’s actual runtime address, making the test environment more reliable and flexible.
    • Improved how the mock storage endpoint is initialized so it no longer depends on a fixed port.

@ti-chi-bot ti-chi-bot Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign winkyao for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 43303120-d805-44b3-ad9f-95ffa56b0014

📥 Commits

Reviewing files that changed from the base of the PR and between 8be4bd0 and a5965fb.

📒 Files selected for processing (1)
  • tests/realtikvtest/importintotest4/main_test.go

📝 Walkthrough

Walkthrough

The test's fake GCS endpoint configuration was changed so that gcsEndpoint is derived from the fakestorage server's actual runtime URL rather than a static host/port, addressing a flaky test caused by port binding issues.

Changes

Mock GCS Endpoint Fix

Layer / File(s) Summary
GCS endpoint configuration and runtime construction
tests/realtikvtest/importintotest4/main_test.go
gcsPort default changed to 0, gcsEndpointFormat updated to a URL-based "%s/storage/v1/" pattern, and gcsEndpoint is now built in SetupSuite using the fakestorage server's runtime URL instead of static formatting.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: approved, lgtm

Suggested reviewers: YangKeao, djshow832, tiancaiamao

Poem

A port once fixed, now free to roam,
The fake GCS server finds its own home.
No more flaky hops, no more test tears,
Just a runtime URL that calms our fears.
🐰 Hop, hop, ship it — the build clears!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: stabilizing the flaky TestImportInto test.
Description check ✅ Passed The description includes the required issue link, problem summary, implementation details, checklist, and release note section.
Linked Issues check ✅ Passed The change directly addresses #69622 by removing the fixed fake GCS port and using a runtime-assigned listener port.
Out of Scope Changes check ✅ Passed The diff is narrowly scoped to the flaky test's fake GCS setup and introduces no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.1101%. Comparing base (8be4bd0) to head (a5965fb).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #69644        +/-   ##
================================================
- Coverage   76.3268%   74.1101%   -2.2167%     
================================================
  Files          2041       2050         +9     
  Lines        560589     576524     +15935     
================================================
- Hits         427880     427263       -617     
- Misses       131808     149054     +17246     
+ Partials        901        207       -694     
Flag Coverage Δ
integration 40.7176% <ø> (+1.0124%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 60.4471% <ø> (ø)
parser ∅ <ø> (∅)
br 47.4650% <ø> (-15.2563%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: TestImportInto in tests/realtikvtest/importintotest4

1 participant