test: stabilize flaky TestImportInto#69644
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test's fake GCS endpoint configuration was changed so that ChangesMock GCS Endpoint Fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69644 +/- ##
================================================
- Coverage 76.3268% 74.1101% -2.2167%
================================================
Files 2041 2050 +9
Lines 560589 576524 +15935
================================================
- Hits 427880 427263 -617
- Misses 131808 149054 +17246
+ Partials 901 207 -694
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
What problem does this PR solve?
Issue Number: close #69622
Problem Summary:
Flaky test
TestImportIntointests/realtikvtest/importintotest4intermittently fails, so this PR stabilizes that path.What changed and how does it work?
Root Cause
Fixed-port fake GCS setup could collide under concurrent RealTiKV execution before TestImportInto reached import assertions.
Fix
Binding to port 0 gives each suite run exclusive listener ownership while preserving the same fake GCS endpoint semantics.
Verification
Spec:
tests/realtikvtest/importintotest4 :: TestImportIntotidb.issue_scoped.v2BASELINE_ONLYGO_TEST_WITH_TAGSintest, deadlockbaseline_onlyObserved result:
Required flaky case was not skipped.
Gate checklist:
Commands:
go test -json -tags=intest,deadlock ./tests/realtikvtest/importintotest4 -run '^TestImportInto$' -count=1Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Fixes #69622
Summary by CodeRabbit