Run go fix with go1.26 by dveeden · Pull Request #12715 · pingcap/tiflow

dveeden · 2026-06-15T08:07:50Z

What problem does this PR solve?

Issue Number: ref #12691

What is changed and how it works?

Same as #12692 but with Go 1.26 and without removing the GODEBUG options that are removed in Go 1.27.

This can be applied to make the change in #12692 smaller

Check List

Tests

Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

ti-chi-bot · 2026-06-15T08:08:02Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716, yudongusa for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dveeden · 2026-06-15T08:09:09Z

/cc @OliverS929 @kennytm

gemini-code-assist

Code Review

This pull request performs a large-scale refactoring across the codebase, replacing interface{} with any, adopting Go 1.21+ features like slices.Sort, slices.Contains, and maps.Copy, and simplifying loops using for range. However, several critical compilation errors were introduced where a non-existent Go method is called on sync.WaitGroup instead of errgroup.Group. Additionally, there are opportunities to optimize string building using fmt.Fprintf on strings.Builder and to simplify boolean assignments using slices.Contains directly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

codecov · 2026-06-15T08:22:48Z

Codecov Report

❌ Patch coverage is 72.51908% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.8235%. Comparing base (e4a15d2) to head (fd17416).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Components	Coverage Δ
cdc	`57.1638% <76.6990%> (-0.0621%)`	⬇️
dm	`∅ <ø> (∅)`
engine	`50.5654% <57.1428%> (-0.0893%)`	⬇️

Flag	Coverage Δ
cdc	`57.1638% <76.6990%> (?)`
unit	`55.8235% <72.5190%> (+2.1993%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #12715        +/-   ##
================================================
+ Coverage   53.6242%   55.8235%   +2.1993%     
================================================
  Files          1038        737       -301     
  Lines        146348      87069     -59279     
================================================
- Hits          78478      48605     -29873     
+ Misses        61961      35005     -26956     
+ Partials       5909       3459      -2450

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dveeden · 2026-06-15T08:47:04Z

/cc @wuhuizuo

kennytm

~380 files remain unreviewed, i'll check the rest in the next batch tomorrow

preferably tell your Claude to fix those maps.Copy → maps.Clone and sb.WriteString(fmt.Sprintf(...)) → fmt.Fprintf(&sb, ...) in all other files.

kennytm · 2026-06-15T15:03:09Z

 			setFK = true
 		}
-		dsn += fmt.Sprintf("&%s='%s'", key, url.QueryEscape(val))
+		dsn.WriteString(fmt.Sprintf("&%s='%s'", key, url.QueryEscape(val)))


Suggested change

dsn.WriteString(fmt.Sprintf("&%s='%s'", key, url.QueryEscape(val)))

fmt.Fprintf(&dsn, "&%s='%s'", key, url.QueryEscape(val))

kennytm · 2026-06-15T15:04:24Z

 	locks := make(map[string]*Lock, len(lk.locks))
-	for k, v := range lk.locks {
-		locks[k] = v
-	}
+	maps.Copy(locks, lk.locks)


Suggested change

locks := make(map[string]*Lock, len(lk.locks))

for k, v := range lk.locks {

locks[k] = v

}

maps.Copy(locks, lk.locks)

locks := maps.Clone(lk.locks)

kennytm · 2026-06-15T15:05:15Z

-		}
-	}
-	return false
+	return slices.Contains(s, e)


better find out who calls contains and replace them with slice.Contains

kennytm · 2026-06-15T15:05:42Z

 	locks := make(map[string]*Lock, len(lk.locks))
-	for k, v := range lk.locks {
-		locks[k] = v
-	}
+	maps.Copy(locks, lk.locks)


Suggested change

locks := make(map[string]*Lock, len(lk.locks))

for k, v := range lk.locks {

locks[k] = v

}

maps.Copy(locks, lk.locks)

locks := maps.Clone(lk.locks)

kennytm · 2026-06-15T15:06:08Z

 	ret := make(map[string]bool, len(l.ready))
-	for k, v := range l.ready {
-		ret[k] = v
-	}
+	maps.Copy(ret, l.ready)


Suggested change

ret := make(map[string]bool, len(l.ready))

for k, v := range l.ready {

ret[k] = v

}

maps.Copy(ret, l.ready)

ret := maps.Clone(l.ready)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Co-authored-by: kennytm <kennytm@gmail.com>

Replace the make + maps.Copy pattern with maps.Clone where a fresh map is created and fully populated from a source map. Applies the PR review suggestions and the same simplification found elsewhere in the codebase. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

ti-chi-bot · 2026-06-16T07:03:27Z

@dveeden: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-error-log-review	`bc914b5`	link	true	`/test pull-error-log-review`
pull-check	`bc914b5`	link	true	`/test pull-check`
pull-cdc-integration-storage-test	`bc914b5`	link	true	`/test pull-cdc-integration-storage-test`
pull-cdc-integration-pulsar-test	`bc914b5`	link	true	`/test pull-cdc-integration-pulsar-test`
pull-cdc-integration-kafka-test	`bc914b5`	link	true	`/test pull-cdc-integration-kafka-test`
pull-cdc-integration-mysql-test	`bc914b5`	link	true	`/test pull-cdc-integration-mysql-test`
pull-dm-integration-test	`bc914b5`	link	true	`/test pull-dm-integration-test`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dveeden · 2026-06-16T07:04:28Z

I'm closing this PR and I'm going to split it up into multiple PRs:

Makes it easier to review
Required for the pull-error-log-review check
Makes approval easier

Run go fix with go1.26

fd17416

ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. labels Jun 15, 2026

ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 15, 2026

ti-chi-bot Bot requested review from OliverS929 and kennytm June 15, 2026 08:09

gemini-code-assist Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread cdc/kv/sharedconn/conn_and_client_test.go

Comment thread cdc/processor/memquota/mem_quota_test.go

Comment thread cmd/kafka-consumer/main.go

Comment thread dm/pkg/conn/basedb.go Outdated

Comment thread cdc/api/middleware/middleware.go Outdated

Run make fmt

aa04847

ti-chi-bot Bot requested a review from wuhuizuo June 15, 2026 08:47

kennytm reviewed Jun 15, 2026

View reviewed changes

dveeden and others added 7 commits June 16, 2026 08:12

Update dm/pkg/conn/basedb.go

37854dc

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update cdc/model/owner.go

cc8d68d

Co-authored-by: kennytm <kennytm@gmail.com>

Update cmd/oauth2-server/main.go

3e735a9

Co-authored-by: kennytm <kennytm@gmail.com>

Manually apply suggestion

5635fac

Manually apply suggestion

2052318

Manually apply suggestion

e50d634

dveeden closed this Jun 16, 2026

	dsn.WriteString(fmt.Sprintf("&%s='%s'", key, url.QueryEscape(val)))
	fmt.Fprintf(&dsn, "&%s='%s'", key, url.QueryEscape(val))

Uh oh!

Conversation

dveeden commented Jun 15, 2026

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Uh oh!

ti-chi-bot Bot commented Jun 15, 2026

Uh oh!

dveeden commented Jun 15, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dveeden commented Jun 15, 2026

Uh oh!

kennytm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kennytm Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

kennytm Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

kennytm Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

kennytm Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

kennytm Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot Bot commented Jun 16, 2026

Uh oh!

dveeden commented Jun 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jun 15, 2026 •

edited

Loading

kennytm left a comment •

edited

Loading