Skip to content

docs: update Go version requirement to 1.25.10 (release-8.5)#12746

Open
wuhuizuo wants to merge 1 commit into
release-8.5from
update-go-version-docs-release-8.5
Open

docs: update Go version requirement to 1.25.10 (release-8.5)#12746
wuhuizuo wants to merge 1 commit into
release-8.5from
update-go-version-docs-release-8.5

Conversation

@wuhuizuo

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

The go.mod declares go 1.25.10, but three documentation files still reference Go 1.23 as the minimum version requirement.

Issue Number: ref https://github.com/pingcap/tiflow/issues/xxx

What is changed and how it works?

Update Go version requirement in 3 documentation files to match go.mod:

  • README_DM.md: Go >= 1.23Go >= 1.25.10
  • README_TiCDC.md: Go >= 1.23Go >= 1.25.10
  • CONTRIBUTING.md: Go 1.23+Go 1.25.10+

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?

No. Documentation-only change.

Do you need to update user documentation, design documentation or monitoring documentation?

No. This PR itself is a documentation update.

Release note

None

Update Go version in README_DM.md, README_TiCDC.md, and CONTRIBUTING.md
to match go.mod declaration of go 1.25.10.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jun 25, 2026
@wuhuizuo wuhuizuo added the skip-issue-check Indicates that a PR no need to check linked issue. label Jun 25, 2026
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum required Go version from 1.23 to 1.25.10 in the CONTRIBUTING.md, README_DM.md, and README_TiCDC.md documentation files. All of the review comments have been filtered out because they comment on version numbers in non-code documentation changes, so there is no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@wuhuizuo wuhuizuo added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 25, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 25, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-06-25 05:43:00.004709736 +0000 UTC m=+185463.667935249: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 25, 2026
@wuhuizuo

Copy link
Copy Markdown
Contributor Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@tenfyzhong: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot

ti-chi-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tenfyzhong, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants