Skip to content

ch4/ofi: make seg_sz a multiple of datatype size #7897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colleeneb wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −12
Open

ch4/ofi: make seg_sz a multiple of datatype size #7897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b45ce
ch4/netmod/ofi: make seg_sz a multiple of the datatype extent
colleeneb Jul 23, 2026
535dbe1
ch4/ofi: fix alignment issue in am_isend_pipeline
hzhou Jul 23, 2026
d9c0fcf
ch4/ofi: remove the dead branch in MPIDI_OFI_am_init_sreq
hzhou Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/mpid/ch4/netmod/ofi/ofi_am_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,24 +184,27 @@ MPL_STATIC_INLINE_PREFIX int MPIDI_OFI_am_init_sreq(const void *am_hdr, size_t a
MPIR_FUNC_ENTER;

MPIR_Assert(am_hdr_sz < (1ULL << MPIDI_OFI_AM_HDR_SZ_BITS));
MPIR_Assert(MPIDI_OFI_AMREQUEST(sreq, sreq_hdr) == NULL);

if (MPIDI_OFI_AMREQUEST(sreq, sreq_hdr) == NULL) {
int vci = MPIDI_Request_get_vci(sreq);
MPIDU_genq_private_pool_alloc_cell(MPIDI_OFI_global.per_vci[vci].am_hdr_buf_pool,
(void **) &sreq_hdr);
MPIR_Assert(sreq_hdr);
MPIDI_OFI_AMREQUEST(sreq, sreq_hdr) = sreq_hdr;
int vci = MPIDI_Request_get_vci(sreq);
MPIDU_genq_private_pool_alloc_cell(MPIDI_OFI_global.per_vci[vci].am_hdr_buf_pool,
(void **) &sreq_hdr);
MPIR_Assert(sreq_hdr);
MPIDI_OFI_AMREQUEST(sreq, sreq_hdr) = sreq_hdr;

sreq_hdr->am_hdr = (void *) &sreq_hdr->am_hdr_buf[0];
sreq_hdr->am_hdr_sz = am_hdr_sz;
sreq_hdr->pack_buffer = NULL;
} else {
sreq_hdr = MPIDI_OFI_AMREQUEST(sreq, sreq_hdr);
}
sreq_hdr->am_hdr = (void *) &sreq_hdr->am_hdr_buf[0];
sreq_hdr->am_hdr_sz = am_hdr_sz;
sreq_hdr->pack_buffer = NULL;

if (am_hdr) {
MPIR_Memcpy(sreq_hdr->am_hdr, am_hdr, am_hdr_sz);
}
#ifdef NEEDS_STRICT_ALIGNMENT
/* adjust am_hdr_sz so the payload will always start aligned */
if (am_hdr_sz % MAX_ALIGNMENT) {
sreq_hdr->am_hdr_sz += (MAX_ALIGNMENT - am_hdr_sz % MAX_ALIGNMENT);
}
#endif

MPIR_FUNC_EXIT;
return mpi_errno;
Expand Down