Repository navigation
Version 2.3.0 Release - #71
Merged
Merged
Conversation
The native Pokepay pod raised its minimum deployment target to iOS 15.0 in 2.3.0, because Xcode 26 and later refuse to build anything below it. - Bump the pod dependency to Pokepay 2.3.0 and raise s.platform to 15.0. - Drop `import Result` from SwiftPokepaySdkPlugin. Pokepay 2.3.0 removed its antitypical/Result dependency, so the pod is no longer installed and the import would not compile. The `Result` values the plugin handles are the standard library's, which is what that package had resolved to since Swift 5 anyway. No Dart-facing API changed. - Document the iOS setup consuming apps now need: `platform :ios, '15.0'` plus a post_install hook raising IPHONEOS_DEPLOYMENT_TARGET for every pod. The hook is not optional -- APIKit declares iOS 9.0 and the Flutter pod declares 11.0, and both fail the build without it. It must run after flutter_additional_ios_build_settings, which resets it. - Apply the same setup to the example app the ios-build CI job generates. Verified against the published pod: a generated Flutter app resolves APIKit 5.4.0 / Pokepay 2.3.0 / pokepay_sdk 2.3.0 with no Result pod, and the plugin target builds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the newly published iOS
Pokepay2.3.0 and bumps the plugin to 2.3.0.Why
Pokepay 2.3.0 (pokepay/ios-sdk#128) raised its minimum deployment target to iOS 15.0, because Xcode 26 and later refuse to build anything below that, and dropped the dead
antitypical/Resultdependency.Changes
ios/pokepay_sdk.podspec—Pokepay2.2.1 → 2.3.0,s.platform12.0 → 15.0, version → 2.3.0.ios/Classes/SwiftPokepaySdkPlugin.swift— droppedimport Result. Required, not cosmetic: the pod is no longer in the dependency graph, so the import would not compile. TheResultvalues the plugin handles are the standard library's, which is what that package had resolved to since Swift 5 anyway. No Dart-facing API changed.README.md— new Requirements + iOS setup section..github/workflows/ci.yml— theios-buildjob applies the same setup to the example app it generates.pubspec.yaml/CHANGELOG.md— 2.3.0.platform :ios, '15.0'alone is not enough. Every app embedding this plugin also needs apost_installhook — the first verification build failed on two pods, not one:APIKit(transitive, last released 2021) declares iOS 9.0 and Flutter's own pod declares 11.0. The hook must run afterflutter_additional_ios_build_settings(target), which resets the setting:The
Runnertarget's own minimum deployment must be 15.0 too. All of this is in the README.Verification
Generated a throwaway Flutter app, added the plugin by path, and resolved against the published pod (no local overrides,
Pods/andPodfile.lockdeleted first):No
Resultpod, andxcodebuild -target pokepay_sdk→** BUILD SUCCEEDED **.Notes
pokepaylibstays at 2.2.0 — unchanged, as in the 2.2.1 and 2.2.2 releases.🤖 Generated with Claude Code