Repository navigation
Migrate metrics export from OTel Arrow to OTLP - #35
Merged
Merged
Conversation
Drops the experimental otel-arrow protocol and sends pmetric.Metrics through the standard OTLP/gRPC unary export from collector pdata's pmetricotlp package. The data model, NVML producers, and gRPC dialer (auth, retries, headers) are unchanged — only the wire layer swaps. Also fix MockProducer.Collect to block on ctx so the agent doesn't exit before the first export tick when running with the mock.
yomete
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the experimental otel-arrow dependency in favor of plain OTLP/gRPC. The agent already produces
pmetric.Metricsfrom collector pdata, which is the OTLP data model, so the swap is mostly a wire-layer change:pmetricotlp.NewExportRequestFromMetricspluspmetricotlp.NewGRPCClientreuse the existing*grpc.ClientConn(and with it all the auth, TLS, retry, and header plumbing). NVML producers, the per-device sample buffer, and the lifecycle wiring are untouched.One side-fix tagged on:
MockProducer.Collectreturned nil immediately, which made the run group shut down before the first export tick. It now blocks onctx.Done()so the mock actually exercises the export path end to end.