Skip to content

Add package: 2025_Maravall_Lopez_Argentina - #204

Open
SioziosK wants to merge 6 commits into
mainfrom
2025_Maravall_Lopez_Argentina
Open

Add package: 2025_Maravall_Lopez_Argentina#204
SioziosK wants to merge 6 commits into
mainfrom
2025_Maravall_Lopez_Argentina

Conversation

@SioziosK

@SioziosK SioziosK commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Linked to #198

PR Checklist

  • The PR title is in the format Add/Update package: {package_name}.
  • The PR description includes a link to the issue requesting the package its
    update. (Add to Linked to #198 above.)

If adding or updating a package:

SSF file Todo list

  • This PR contains a sequencingSourceFile (.ssf) for the requested
    package.
  • The name of the .ssf file(s) matches the package name (i.e.
    packages/2023_my_package/2023_my_package.ssf).
  • The .ssf file MUST contain a new line at the end of the file.
    A check for this exists in the CI. This check should pass before
    you continue with this list.
  • I confirm that the poseidon_IDs, udg, and library_built are filled
    and correct.
  • I made sure to leave notes where necessary to explain any special
    cases/judgement calls made for data entries.

Include a Janno file

It is recommended that you include a janno file for the requested package to the PR.
While optional, recipes that include a janno file will be prioritised for processing.

  • (optional) This PR contains a janno file (.janno) for the requested
    package.
    • The name of the .janno file(s) matches the package name (i.e.
      packages/2023_my_package/2023_my_package.janno).
    • The .janno file contains one record per poseidon_id specified in the SSF file.

Recipe creation and validation

  • Comment @delphis-bot create recipe to this pull request to awaken
    Poseidon's trusty helper. (This should be repeated whenever changes are
    made to the SSF file contents).

After a few second, Delphis-bot will add a number of files to the PR.
Using the 'Files changed' tab, check that all of the following files were added:

  • The file packages/{package_name}/{package_name}.tsv was added to the PR.
  • The file packages/{package_name}/{package_name}.tsv_patch.sh was added
    to the PR from template.
  • The file packages/{package_name}/script_versions.txt was added to the
    PR.
  • The file packages/{package_name}/{package_name}.config was added to the
    PR from template.

Additional configuration

Additional configuration may be required when processing the data through nf-core/eager.
If you think this may be the case here, please either leave a comment about it in the PR or
add the relevant parameters within the params section at the end of the package config file.
For example, if the published data from the paper have internal barcodes, please mention that
in a comment, or provide the relevant nf-core/eager parameters in the params section.

  • If any nf-core/eager parameters need to be altered from their defaults, I
    have commented so in this PR (or added the relevant parameters within the
    params section at the end of the package config file).

@SioziosK SioziosK changed the title Create 2025_MARAVALL_LOPEZ_ARGENTINA.ssf Add package: 2025_Maravall_Lopez_Argentina Apr 12, 2026
@github-actions github-actions Bot added new package has janno The PR includes a janno file labels Jun 18, 2026
@SioziosK

Copy link
Copy Markdown
Contributor Author

@delphis-bot create recipe

@delphis-bot

Copy link
Copy Markdown
Collaborator

SSF files MUST be named after their respective package. The following SSF files break this rule:
packages/2025_Maravall_Lopez_Argentina/2025_MARAVALL_LOPEZ_ARGENTINA.ssf

@SioziosK

Copy link
Copy Markdown
Contributor Author

@delphis-bot create recipe

@SioziosK

Copy link
Copy Markdown
Contributor Author

@TCLamnidis I have uploaded both the .janno and SSF file. In the .janno file in the columns UDG and Library_Built for the samples that had multiple libraries I kept the least udg treated (for example if there were both half and plus libraries, I wrote down half) and ds if there was a mix of ds and ss, even though in the publication they provide info for each library separately. If needed I can reupload with the info for each library separated by ;. In the Endogenous column a different number was provided for each library in the publication and I left that as it was, each number separated by ;. That created an issue in the .janno validation. Let me know if I should fix that.

@SioziosK
SioziosK marked this pull request as draft June 18, 2026 20:36
@SioziosK
SioziosK requested a review from TCLamnidis June 18, 2026 20:37
@TCLamnidis
TCLamnidis marked this pull request as ready for review August 11, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has janno The PR includes a janno file new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants