fix(writer): boxplot produces invalid Vega-Lite spec#449
Open
cpsievert wants to merge 1 commit into
Open
Conversation
Skip the boxplot stat's internal "type" aesthetic when building Vega-Lite encoding channels and strip the y2 encoding on whisker/box layers down to just the field reference. Add a schema-validated boxplot test. Closes posit-dev#448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"type"aesthetic when building Vega-Lite encoding channels — it's structural (consumed during data preparation), not a visual channel.y2encoding on whisker/box layers down to just{"field": ...}— secondary position channels don't acceptaxis,scale,type, orstack.test_geom_boxplotonly checked\!json.is_empty()).Closes #448
Test plan
test_boxplot_schema_validationvalidates output against VL v6 JSON Schema