Repository navigation
Allow output info to view - #583
Merged
Merged
Conversation
teunbrand
approved these changes
Oct 12, 2026
teunbrand
left a comment
teunbrand
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but would be nice if we can keep frame settings in one place.
Comment on lines
+170
to
+174
| pub struct ClosingFrame { | ||
| pub width: u32, | ||
| pub height: u32, | ||
| pub dpi: f64, | ||
| } |
Collaborator
There was a problem hiding this comment.
Just noting that this is a strict subset of the Canvas struct. It'd be nice if somehow we only have the collection of width/height/dpi settings in one spot, instead of multiple.
Teun's review: ClosingFrame was a strict subset of Canvas. Extract
Dimensions { width, height, dpi } from Canvas, embed it there, and have
the viewer's show() return it instead of a duplicate ClosingFrame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #562
This PR adds the option of passing in output args to
ggsql viewwhich will then render to a file once the window is closed using the dimensions of the window for the output