Repository navigation
Conversation
Assign each result row a group id from its facet values (nested by variable, nulls in one group per level), reorder rows so groups are contiguous, and stamp body rows with their group id for label-cell generation.
Faceted tables emit one GroupHeading row per changed facet-variable level above each group (hierarchical for several variables), with labels read from the group's first formatted row; the facet columns leave the body. Column-claim conflicts (SPAN/STUB over a facet variable) are rejected by Table::validate_boundaries. place => 'left' is rejected until group-stub columns land.
Nulls in a facet variable form their own group, sorted first or last, or their rows are dropped from the table; default 'last'.
Joins nested group labels into one ('north - q1'), collapsing label rows
or group stub columns to a single level.
This comment was marked as resolved.
This comment was marked as resolved.
thomasp85
reviewed
Nov 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
thomasp85
reviewed
Nov 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
That is most review comments resolved. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the
FACETclause for grouping purposes.I've left out the aggregation utility proposed for facets, because I think they can do with a little more discussion.
Essentially the facet clause designates columns to be group headings, and these either get rendered as interleaved group label rows, or as group label columns.
Our
FACET fooroughly corresponds togt(groupname_col = "foo")andFACET SETTING place => 'left'totab_options(row_group.as_column = TRUE).In contrast to
VISUALISE ... FACET, I've allowed multiple variables, which means we might miss out onSCALE panel ..., but I'm content with that for now.In contrast to gt's grouping logic, we do not collapse labels of multiple variables by default. Multiple nesting levels are displayed as separate rows or columns by default. A
separatorargument can be used to concatenate the labels.