Archive and compare iterations.log for implicit coupling#743
Archive and compare iterations.log for implicit coupling#743PranjalManhgaye wants to merge 3 commits into
Conversation
|
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/gsoc-2026-pranjal-manhgaye/2769/5 |
|
@PranjalManhgaye could you please resolve the merge conflicts and prepare this PR for reviewing? |
MakisH
left a comment
There was a problem hiding this comment.
Some first comments. I have not yet looked at the complete PR or tested it.
|
thanks @MakisH for your review , i will make this pr review ready and also resolve conflicts . |
Archive precice-*-iterations.log files during system tests and compare them against reference copies for implicit-coupling regression checks.
4ed9d9f to
4a1885d
Compare
|
Hi @MakisH , rebased onto develop, updated the PR description, and replied on your review threads. ready for another look when you have time. |
There was a problem hiding this comment.
I have not yet completed my review, but here is already a first comment on something to check.
Tests I have executed locally:
python3 systemtests.py --suites="openfoam_adapter_release"(no iterations in the reference results) succeedspython3 generate_reference_results.py --suites="openfoam_adapter_release"worked and generated results in an (uncompressed) folderflow-over-heated-plate/reference-results/fluid-openfoam_solid-openfoam.iterations-logswithfluid-openfoam/precice-Fluid-iterations.logandsolid-openfoam/precice-Solid-iterations.log.- after updating the reference results:
python3 systemtests.py --suites="openfoam_adapter_release"worked, but I don't seesha256oriterationsin the output to confirm.
Remove legacy .iterations-hashes.json support and log INFO when iterations.log SHA-256 comparison passes so reviewers can confirm it ran.
Summary
Implicit coupling tutorials write precice-*-iterations.log files that show how many coupling iterations each time step needed. This PR adds system-test support to save those logs and check them against reference copies, so we notice when coupling behaviour changes unexpectedly. Closes #440.
Changes
precice-*-iterations.logfiles intoiterations-logs/and compare them by SHA-256 hash against archived reference copies in a*.iterations-logs/directory next to each reference.tar.gz. A successful check is logged at INFO; a mismatch fails the test.test (local)
Notes
Checklist
changelog-entries/743.md