Skip to content

Fix CI: upgrade ESLint to 10 compatibility#344

Closed
Copilot wants to merge 7 commits intodependabot/npm_and_yarn/eslint-10.0.3from
copilot/sub-pr-339
Closed

Fix CI: upgrade ESLint to 10 compatibility#344
Copilot wants to merge 7 commits intodependabot/npm_and_yarn/eslint-10.0.3from
copilot/sub-pr-339

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

eslint-plugin-github@6.0.0 only supports eslint@^8 || ^9, blocking the ESLint 10 upgrade. The flat config wasn't actively using any rules from that plugin (all were turned off), making removal safe.

Changes

  • package.json: Remove eslint-plugin-github; add missing @eslint/js (required by flat config)
  • eslint.config.js: Remove eslint-plugin-github import and its unused rule overrides (github/no-inner-html, i18n-text/no-en)
  • global-announce.ts: Fix no-useless-assignment error introduced by ESLint 10's new rule — replaced let + redundant null init with const declarations

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

dependabot Bot and others added 2 commits March 9, 2026 21:56
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.0.3.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.2...v10.0.3)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: 7d7977d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/eslint-10.0.3 branch from 3253b80 to 637e20c Compare March 9, 2026 22:03
…o-useless-assignment

Co-authored-by: liuliu-dev <6688812+liuliu-dev@users.noreply.github.com>
Copilot AI changed the title [WIP] Bump ESLint from 9.39.2 to 10.0.3 Fix CI: upgrade ESLint to 10 compatibility Mar 9, 2026
@liuliu-dev
Copy link
Copy Markdown
Contributor

@copilot resolve conflicts

Co-authored-by: liuliu-dev <6688812+liuliu-dev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot resolve conflicts

Resolved in commit 3e1f08f. The base branch had accumulated additional dependency bumps (@changesets/cli^2.30.0, publint^0.3.18, a11y-dialog^8.1.5) that weren't reflected in our branch. Updated all three package.json files and regenerated package-lock.json.

@liuliu-dev
Copy link
Copy Markdown
Contributor

@copilot resolve conflicts

…onflicts

Co-authored-by: liuliu-dev <6688812+liuliu-dev@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot resolve conflicts

Resolved in commit 360f99f. The package-lock.json had diverged because both branches made substantial changes to it — regenerated it by starting from the base branch's lock file then re-running npm install with our package.json (which removes eslint-plugin-github and adds @eslint/js). This produces a lock file that is forward-based on the base branch, clearing the merge conflict.

@liuliu-dev liuliu-dev closed this Mar 9, 2026
@liuliu-dev liuliu-dev deleted the copilot/sub-pr-339 branch March 9, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants